Re: [PATCH-for-10.0 v2 01/13] hw/pci: Do not declare PCIBus::flags mask as enum

2024-12-03 Thread Thomas Huth
On 27/11/2024 10.37, Philippe Mathieu-Daudé wrote: On 26/11/24 12:22, Philippe Mathieu-Daudé wrote: We use PCIBus::flags to mask various flags. It is not an enum, and doing so confuses static analyzers. Rename the enum as singular. Use a generic unsigned type for the mask. Signed-off-by: Philip

Re: [PATCH-for-10.0 v2 01/13] hw/pci: Do not declare PCIBus::flags mask as enum

2024-11-27 Thread Philippe Mathieu-Daudé
On 26/11/24 12:22, Philippe Mathieu-Daudé wrote: We use PCIBus::flags to mask various flags. It is not an enum, and doing so confuses static analyzers. Rename the enum as singular. Use a generic unsigned type for the mask. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci/pci_bus.h | 4

[PATCH-for-10.0 v2 01/13] hw/pci: Do not declare PCIBus::flags mask as enum

2024-11-26 Thread Philippe Mathieu-Daudé
We use PCIBus::flags to mask various flags. It is not an enum, and doing so confuses static analyzers. Rename the enum as singular. Use a generic unsigned type for the mask. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/pci/pci_bus.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(