Re: [PATCH] xio3130_upstream: Add ACS (Access Control Services) capability

2022-08-14 Thread Michael S. Tsirkin
On Sun, Aug 14, 2022 at 11:59:51PM +0800, Paul Schlacter wrote: > What's wrong with not disabling the old version? Old versions have to behave in the same way as they did, or close enough. Changing that breaks migration between qemu versions. > > > On Sun, Aug 14, 2022 at 6:48 PM Michael S. Tsi

Re: [PATCH] xio3130_upstream: Add ACS (Access Control Services) capability

2022-08-14 Thread Paul Schlacter
What's wrong with not disabling the old version? On Sun, Aug 14, 2022 at 6:48 PM Michael S. Tsirkin wrote: > On Sun, Aug 14, 2022 at 03:47:49PM +0800, Paul Schlacter wrote: > > If it is a pcie device, check that all devices on the path from > > > > the device to the root complex have ACS enable

Re: [PATCH] xio3130_upstream: Add ACS (Access Control Services) capability

2022-08-14 Thread Michael S. Tsirkin
On Sun, Aug 14, 2022 at 03:47:49PM +0800, Paul Schlacter wrote: > If it is a pcie device, check that all devices on the path from > > the device to the root complex have ACS enabled, and then the > > device will become an iommu_group. > > it will have the effect of isolation > > > Signed-off-b

[PATCH] xio3130_upstream: Add ACS (Access Control Services) capability

2022-08-14 Thread Paul Schlacter
If it is a pcie device, check that all devices on the path from the device to the root complex have ACS enabled, and then the device will become an iommu_group. it will have the effect of isolation Signed-off-by: wlfightup --- hw/pci-bridge/xio3130_upstream.c | 3 +++ 1 file changed, 3 in