Re: [PATCH] vnc: add qmp to support change authz

2021-01-11 Thread Gerd Hoffmann
> >> +{ 'command': 'change-vnc-authz', > >> + 'data': { 'type' : 'str', > >> +'index': 'str'}, > >> + 'if': 'defined(CONFIG_VNC_SASL)' } > > > > type should be an enum I think. > It is a good idea to set type to enum, I will fix it in the next version. > > > Also index should be an

Re: [PATCH] vnc: add qmp to support change authz

2021-01-07 Thread Zihao Chang
Hi, On 2021/1/8 0:04, Gerd Hoffmann wrote: > Hi, > >> This patch add a new qmp 'change-vnc-authz' to support change the >> tls/sasl authz of vm. If index='', unset tlsauthzid/sasl.authzid >> { >>"execute":"change-vnc-authz", >>"arguments":{ >> "index":"object-authz-id", >> "

Re: [PATCH] vnc: add qmp to support change authz

2021-01-07 Thread Daniel P . Berrangé
On Thu, Jan 07, 2021 at 08:46:57PM +0800, Zihao Chang wrote: > This patch add a new qmp 'change-vnc-authz' to support change the > tls/sasl authz of vm. If index='', unset tlsauthzid/sasl.authzid > { >"execute":"change-vnc-authz", >"arguments":{ > "index":"object-authz-id", > "t

Re: [PATCH] vnc: add qmp to support change authz

2021-01-07 Thread Gerd Hoffmann
Hi, > This patch add a new qmp 'change-vnc-authz' to support change the > tls/sasl authz of vm. If index='', unset tlsauthzid/sasl.authzid > { >"execute":"change-vnc-authz", >"arguments":{ > "index":"object-authz-id", > "type":"tls/sasl" >} > } > +## > +# @change-vnc-aut

[PATCH] vnc: add qmp to support change authz

2021-01-07 Thread Zihao Chang
This patch add a new qmp 'change-vnc-authz' to support change the tls/sasl authz of vm. If index='', unset tlsauthzid/sasl.authzid { "execute":"change-vnc-authz", "arguments":{ "index":"object-authz-id", "type":"tls/sasl" } } Signed-off-by: Zihao Chang --- include/ui/console