Re: [PATCH] vl: Fix an assert failure in error path

2021-06-10 Thread Peng Liang
On 6/10/2021 3:32 PM, Markus Armbruster wrote: > Peng Liang writes: > >> On 6/9/2021 8:15 PM, Daniel P. Berrangé wrote: >>> On Wed, Jun 09, 2021 at 02:09:47PM +0200, Markus Armbruster wrote: Paolo Bonzini writes: > On 10/06/21 10:47, Zhenzhong Duan wrote: >> Based on the descri

Re: [PATCH] vl: Fix an assert failure in error path

2021-06-10 Thread Paolo Bonzini
On 09/06/21 14:09, Markus Armbruster wrote: Fixes: 03d2b412aaf2078425f8472f31c8a9c2340969eb Actually 0546c0609c ("vl: split various early command line options to a separate function", 2020-12-10). Done, thanks! Paolo

Re: [PATCH] vl: Fix an assert failure in error path

2021-06-10 Thread Markus Armbruster
Peng Liang writes: > On 6/9/2021 8:15 PM, Daniel P. Berrangé wrote: >> On Wed, Jun 09, 2021 at 02:09:47PM +0200, Markus Armbruster wrote: >>> Paolo Bonzini writes: >>> On 10/06/21 10:47, Zhenzhong Duan wrote: > Based on the description of error_setg(), the local variable err in > qe

Re: [PATCH] vl: Fix an assert failure in error path

2021-06-09 Thread Peng Liang
On 6/9/2021 8:15 PM, Daniel P. Berrangé wrote: > On Wed, Jun 09, 2021 at 02:09:47PM +0200, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 10/06/21 10:47, Zhenzhong Duan wrote: Based on the description of error_setg(), the local variable err in qemu_maybe_daemonize() should b

Re: [PATCH] vl: Fix an assert failure in error path

2021-06-09 Thread Daniel P . Berrangé
On Wed, Jun 09, 2021 at 02:09:47PM +0200, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 10/06/21 10:47, Zhenzhong Duan wrote: > >> Based on the description of error_setg(), the local variable err in > >> qemu_maybe_daemonize() should be initialized to NULL. > >> Without fix, the unini

Re: [PATCH] vl: Fix an assert failure in error path

2021-06-09 Thread Markus Armbruster
Paolo Bonzini writes: > On 10/06/21 10:47, Zhenzhong Duan wrote: >> Based on the description of error_setg(), the local variable err in >> qemu_maybe_daemonize() should be initialized to NULL. >> Without fix, the uninitialized *errp triggers assert failure which >> doesn't show much valuable info

Re: [PATCH] vl: Fix an assert failure in error path

2021-06-09 Thread Paolo Bonzini
On 10/06/21 10:47, Zhenzhong Duan wrote: Based on the description of error_setg(), the local variable err in qemu_maybe_daemonize() should be initialized to NULL. Without fix, the uninitialized *errp triggers assert failure which doesn't show much valuable information. Before the fix: qemu-syst

[PATCH] vl: Fix an assert failure in error path

2021-06-09 Thread Zhenzhong Duan
Based on the description of error_setg(), the local variable err in qemu_maybe_daemonize() should be initialized to NULL. Without fix, the uninitialized *errp triggers assert failure which doesn't show much valuable information. Before the fix: qemu-system-x86_64: ../util/error.c:59: error_setv: