Re: [PATCH] virtio-net : Add check for VIRTIO_NET_F_MAC

2021-09-30 Thread Michael Tokarev
30.09.2021 04:35, Cindy Lu wrote: [] so here come to the final question. which mac address has the higher priority? I think the NET_F_MAC bit means the hw mac address > command-line address. if the hw drivers want to change this. they can simply remove this bit. At the very least, qemu should N

Re: [PATCH] virtio-net : Add check for VIRTIO_NET_F_MAC

2021-09-29 Thread Cindy Lu
On Wed, Sep 29, 2021 at 9:36 PM Michael S. Tsirkin wrote: > > On Wed, Sep 29, 2021 at 08:08:40PM +0800, Cindy Lu wrote: > > On Wed, Sep 29, 2021 at 6:07 PM Michael Tokarev wrote: > > > > > > 29.09.2021 09:52, Cindy Lu wrote: > > > > For vdpa device, if the host support VIRTIO_NET_F_MAC > > > > we

Re: [PATCH] virtio-net : Add check for VIRTIO_NET_F_MAC

2021-09-29 Thread Michael S. Tsirkin
On Wed, Sep 29, 2021 at 08:08:40PM +0800, Cindy Lu wrote: > On Wed, Sep 29, 2021 at 6:07 PM Michael Tokarev wrote: > > > > 29.09.2021 09:52, Cindy Lu wrote: > > > For vdpa device, if the host support VIRTIO_NET_F_MAC > > > we need to read the mac address from hardware, so need > > > to check this

Re: [PATCH] virtio-net : Add check for VIRTIO_NET_F_MAC

2021-09-29 Thread Cindy Lu
On Wed, Sep 29, 2021 at 6:07 PM Michael Tokarev wrote: > > 29.09.2021 09:52, Cindy Lu wrote: > > For vdpa device, if the host support VIRTIO_NET_F_MAC > > we need to read the mac address from hardware, so need > > to check this bit, the logic is > > 1 if the host support VIRTIO_NET_F_MAC and the m

Re: [PATCH] virtio-net : Add check for VIRTIO_NET_F_MAC

2021-09-29 Thread Michael Tokarev
29.09.2021 09:52, Cindy Lu wrote: For vdpa device, if the host support VIRTIO_NET_F_MAC we need to read the mac address from hardware, so need to check this bit, the logic is 1 if the host support VIRTIO_NET_F_MAC and the mac address is correct, qemu will use the mac address in hardware 2.if

[PATCH] virtio-net : Add check for VIRTIO_NET_F_MAC

2021-09-28 Thread Cindy Lu
For vdpa device, if the host support VIRTIO_NET_F_MAC we need to read the mac address from hardware, so need to check this bit, the logic is 1 if the host support VIRTIO_NET_F_MAC and the mac address is correct, qemu will use the mac address in hardware 2.if the host not support , qemu will use