Re: [PATCH] virtio-gpu: only compile virtio-gpu-3d.c for CONFIG_VIRGL=y

2020-10-27 Thread Philippe Mathieu-Daudé
On 10/26/20 3:28 PM, Gerd Hoffmann wrote: > There is no actual code in the CONFIG_VIRGL=n case. So building is > (a) pointless and (b) makes macos ranlib complain. > > Reported-by: Paolo Bonzini > Signed-off-by: Gerd Hoffmann > --- > hw/display/virtio-gpu-3d.c | 4 > hw/display/meson.buil

Re: [PATCH] virtio-gpu: only compile virtio-gpu-3d.c for CONFIG_VIRGL=y

2020-10-26 Thread Marc-André Lureau
On Mon, Oct 26, 2020 at 6:29 PM Gerd Hoffmann wrote: > There is no actual code in the CONFIG_VIRGL=n case. So building is > (a) pointless and (b) makes macos ranlib complain. > > Reported-by: Paolo Bonzini > Signed-off-by: Gerd Hoffmann > Reviewed-by: Marc-André Lureau --- > hw/display/vir

[PATCH] virtio-gpu: only compile virtio-gpu-3d.c for CONFIG_VIRGL=y

2020-10-26 Thread Gerd Hoffmann
There is no actual code in the CONFIG_VIRGL=n case. So building is (a) pointless and (b) makes macos ranlib complain. Reported-by: Paolo Bonzini Signed-off-by: Gerd Hoffmann --- hw/display/virtio-gpu-3d.c | 4 hw/display/meson.build | 4 +++- 2 files changed, 3 insertions(+), 5 deleti