Re: [PATCH] vhost-user-gpu: Drop trailing json comma

2019-09-20 Thread Philippe Mathieu-Daudé
On 9/19/19 10:33 PM, Cole Robinson wrote: > Trailing comma is not valid json: > > $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq > parse error: Expected another key-value pair at line 5, column 1 Shouldn't we add this as a test? > Signed-off-by: Cole Robinson > --- > contrib/vhost-user-

Re: [PATCH] vhost-user-gpu: Drop trailing json comma

2019-09-20 Thread Li Qiang
Cole Robinson 于2019年9月20日周五 上午4:34写道： > Trailing comma is not valid json: > > $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq > parse error: Expected another key-value pair at line 5, column 1 > > Signed-off-by: Cole Robinson > Reviewed-by: Li Qiang > --- > contrib/vhost-user-gpu/50-

Re: [PATCH] vhost-user-gpu: Drop trailing json comma

2019-09-19 Thread Marc-André Lureau
On Fri, Sep 20, 2019 at 12:34 AM Cole Robinson wrote: > > Trailing comma is not valid json: > > $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq > parse error: Expected another key-value pair at line 5, column 1 > > Signed-off-by: Cole Robinson oh json.. Reviewed-by: Marc-André Lureau > -

[PATCH] vhost-user-gpu: Drop trailing json comma

2019-09-19 Thread Cole Robinson
Trailing comma is not valid json: $ cat contrib/vhost-user-gpu/50-qemu-gpu.json.in | jq parse error: Expected another key-value pair at line 5, column 1 Signed-off-by: Cole Robinson --- contrib/vhost-user-gpu/50-qemu-gpu.json.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git