Re: [Virtio-fs] [PATCH] vhost-user-fs: fix features handling

2021-04-14 Thread Stefan Hajnoczi
On Tue, Apr 13, 2021 at 09:35:34AM -0400, Vivek Goyal wrote: > On Tue, Apr 13, 2021 at 09:47:14AM +0100, Stefan Hajnoczi wrote: > > On Thu, Apr 08, 2021 at 10:55:34PM +0300, Anton Kuchin wrote: > > > Make virtio-fs take into account server capabilities. > > > > > > Just returning requested feature

Re: [Virtio-fs] [PATCH] vhost-user-fs: fix features handling

2021-04-13 Thread Vivek Goyal
On Tue, Apr 13, 2021 at 09:47:14AM +0100, Stefan Hajnoczi wrote: > On Thu, Apr 08, 2021 at 10:55:34PM +0300, Anton Kuchin wrote: > > Make virtio-fs take into account server capabilities. > > > > Just returning requested features assumes they all of then are implemented > > by server and results in

Re: [PATCH] vhost-user-fs: fix features handling

2021-04-13 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@redhat.com) wrote: > On Thu, Apr 08, 2021 at 10:55:34PM +0300, Anton Kuchin wrote: > > Make virtio-fs take into account server capabilities. > > > > Just returning requested features assumes they all of then are implemented > > by server and results in setting unsupport

Re: [Virtio-fs] [PATCH] vhost-user-fs: fix features handling

2021-04-13 Thread Stefan Hajnoczi
On Mon, Apr 12, 2021 at 02:43:16PM -0400, Vivek Goyal wrote: > On Sun, Apr 11, 2021 at 09:21:54AM +0300, Anton Kuchin wrote: > > > > On 09/04/2021 18:56, Vivek Goyal wrote: > > > On Thu, Apr 08, 2021 at 10:55:34PM +0300, Anton Kuchin wrote: > > > > Make virtio-fs take into account server capabilit

Re: [PATCH] vhost-user-fs: fix features handling

2021-04-13 Thread Stefan Hajnoczi
On Thu, Apr 08, 2021 at 10:55:34PM +0300, Anton Kuchin wrote: > Make virtio-fs take into account server capabilities. > > Just returning requested features assumes they all of then are implemented > by server and results in setting unsupported configuration if some of them > are absent. > > Signe

Re: [Virtio-fs] [PATCH] vhost-user-fs: fix features handling

2021-04-12 Thread Vivek Goyal
On Sun, Apr 11, 2021 at 09:21:54AM +0300, Anton Kuchin wrote: > > On 09/04/2021 18:56, Vivek Goyal wrote: > > On Thu, Apr 08, 2021 at 10:55:34PM +0300, Anton Kuchin wrote: > > > Make virtio-fs take into account server capabilities. > > > > > > Just returning requested features assumes they all of

Re: [Virtio-fs] [PATCH] vhost-user-fs: fix features handling

2021-04-10 Thread Anton Kuchin
On 09/04/2021 18:56, Vivek Goyal wrote: On Thu, Apr 08, 2021 at 10:55:34PM +0300, Anton Kuchin wrote: Make virtio-fs take into account server capabilities. Just returning requested features assumes they all of then are implemented by server and results in setting unsupported configuration if

Re: [Virtio-fs] [PATCH] vhost-user-fs: fix features handling

2021-04-09 Thread Vivek Goyal
On Thu, Apr 08, 2021 at 10:55:34PM +0300, Anton Kuchin wrote: > Make virtio-fs take into account server capabilities. > > Just returning requested features assumes they all of then are implemented > by server and results in setting unsupported configuration if some of them > are absent. > > Signe

[PATCH] vhost-user-fs: fix features handling

2021-04-08 Thread Anton Kuchin
Make virtio-fs take into account server capabilities. Just returning requested features assumes they all of then are implemented by server and results in setting unsupported configuration if some of them are absent. Signed-off-by: Anton Kuchin --- hw/virtio/vhost-user-fs.c | 17 +---