Re: [PATCH] vhost-user-blk: Fix two resource leaks

2020-10-28 Thread AlexChen
On 2020/10/28 23:40, Raphael Norwitz wrote: > The change looks good but I'm not sure I'd call it resource leak in > either case since the failure case kills vhost-user-blk/scsi. In the > commit message maybe rather say "vhost-user-blk/scsi: fix broken error > handling for socket call"? > Thanks fo

Re: [PATCH] vhost-user-blk: Fix two resource leaks

2020-10-28 Thread Raphael Norwitz
The change looks good but I'm not sure I'd call it resource leak in either case since the failure case kills vhost-user-blk/scsi. In the commit message maybe rather say "vhost-user-blk/scsi: fix broken error handling for socket call"? On Wed, Oct 28, 2020 at 10:10 AM AlexChen wrote: > > When sock

[PATCH] vhost-user-blk: Fix two resource leaks

2020-10-28 Thread AlexChen
When socket() fails, it returns -1, 0 is the normal return value and should not return Reported-by: Euler Robot Signed-off-by: AlexChen --- contrib/vhost-user-blk/vhost-user-blk.c | 2 +- contrib/vhost-user-scsi/vhost-user-scsi.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff