Re: [PATCH] vdpa: Fix endian bugs in shadow virtqueue

2025-02-12 Thread Eugenio Perez Martin
On Wed, Feb 12, 2025 at 4:37 PM Konstantin Shkolnyy wrote: > > On 2/12/2025 09:06, Eugenio Perez Martin wrote: > >> -i = cpu_to_le16(svq->desc_next[i]); > >> +i = le16_to_cpu(svq->desc_next[i]); > > > > Both svq->desc_next and "i" are in QEMU. We can skip the conversion > > and ass

Re: [PATCH] vdpa: Fix endian bugs in shadow virtqueue

2025-02-12 Thread Konstantin Shkolnyy
On 2/12/2025 09:06, Eugenio Perez Martin wrote: -i = cpu_to_le16(svq->desc_next[i]); +i = le16_to_cpu(svq->desc_next[i]); Both svq->desc_next and "i" are in QEMU. We can skip the conversion and assign directly. Are you saying that desc_next[] should be in "CPU" and not LE form

Re: [PATCH] vdpa: Fix endian bugs in shadow virtqueue

2025-02-12 Thread Eugenio Perez Martin
On Tue, Feb 11, 2025 at 5:20 PM Konstantin Shkolnyy wrote: > > VDPA didn't work on a big-endian machine due to missing/incorrect > CPU<->LE data format conversions. > Thank you very much for this! > Signed-off-by: Konstantin Shkolnyy > --- > hw/virtio/vhost-shadow-virtqueue.c | 16 +---

[PATCH] vdpa: Fix endian bugs in shadow virtqueue

2025-02-11 Thread Konstantin Shkolnyy
VDPA didn't work on a big-endian machine due to missing/incorrect CPU<->LE data format conversions. Signed-off-by: Konstantin Shkolnyy --- hw/virtio/vhost-shadow-virtqueue.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/virtio/vhost-shadow-virtqueue.c b