Re: [PATCH] usb: allow max 8192 bytes for desc

2022-01-11 Thread Philippe Mathieu-Daudé
On 1/11/22 13:27, zhenwei pi wrote: > On 1/11/22 8:25 PM, Daniel P. Berrangé wrote: >> On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote: >>> On Tue, 11 Jan 2022 at 10:54, zhenwei pi >>> wrote: A device of USB video class usually uses larger desc structure, so use larger

Re: Re: Re: [PATCH] usb: allow max 8192 bytes for desc

2022-01-11 Thread zhenwei pi
On 1/11/22 8:38 PM, Daniel P. Berrangé wrote: On Tue, Jan 11, 2022 at 08:27:35PM +0800, zhenwei pi wrote: On 1/11/22 8:25 PM, Daniel P. Berrangé wrote: On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote: On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote: A device of USB video clas

Re: Re: [PATCH] usb: allow max 8192 bytes for desc

2022-01-11 Thread Daniel P . Berrangé
On Tue, Jan 11, 2022 at 08:27:35PM +0800, zhenwei pi wrote: > > > On 1/11/22 8:25 PM, Daniel P. Berrangé wrote: > > On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote: > > > On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote: > > > > > > > > A device of USB video class usually uses large

Re: Re: [PATCH] usb: allow max 8192 bytes for desc

2022-01-11 Thread zhenwei pi
On 1/11/22 8:25 PM, Daniel P. Berrangé wrote: On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote: On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote: A device of USB video class usually uses larger desc structure, so use larger buffer to avoid failure. (dev-video.c is ready) Alloca

Re: [PATCH] usb: allow max 8192 bytes for desc

2022-01-11 Thread Daniel P . Berrangé
On Tue, Jan 11, 2022 at 12:21:42PM +, Peter Maydell wrote: > On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote: > > > > A device of USB video class usually uses larger desc structure, so > > use larger buffer to avoid failure. (dev-video.c is ready) > > > > Allocating memory dynamically by g_mall

Re: [PATCH] usb: allow max 8192 bytes for desc

2022-01-11 Thread Peter Maydell
On Tue, 11 Jan 2022 at 10:54, zhenwei pi wrote: > > A device of USB video class usually uses larger desc structure, so > use larger buffer to avoid failure. (dev-video.c is ready) > > Allocating memory dynamically by g_malloc of the orignal version of > this change, Philippe suggested just using t

Re: [PATCH] usb: allow max 8192 bytes for desc

2022-01-11 Thread Philippe Mathieu-Daudé
On 1/11/22 11:49, zhenwei pi wrote: > A device of USB video class usually uses larger desc structure, so > use larger buffer to avoid failure. (dev-video.c is ready) > > Allocating memory dynamically by g_malloc of the orignal version of > this change, Philippe suggested just using the stack. Test

[PATCH] usb: allow max 8192 bytes for desc

2022-01-11 Thread zhenwei pi
A device of USB video class usually uses larger desc structure, so use larger buffer to avoid failure. (dev-video.c is ready) Allocating memory dynamically by g_malloc of the orignal version of this change, Philippe suggested just using the stack. Test the two versions of qemu binary, the size of