Re: [PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later

2020-02-08 Thread Jan Kiszka
On 16.01.20 02:12, Philippe Mathieu-Daudé wrote: > The GdkMonitor was introduced in GTK+ 3.22: > https://developer.gnome.org/gdk3/stable/api-index-3-22.html#api-index-3.22 > > If we build with older GTK+, the build fails: > > CC ui/gtk.o >qemu/ui/gtk.c: In function ‘gd_vc_gfx_init’: >

Re: [PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later

2020-01-16 Thread Philippe Mathieu-Daudé
On 1/16/20 11:16 AM, Daniel P. Berrangé wrote: On Thu, Jan 16, 2020 at 02:12:17AM +0100, Philippe Mathieu-Daudé wrote: The GdkMonitor was introduced in GTK+ 3.22: https://developer.gnome.org/gdk3/stable/api-index-3-22.html#api-index-3.22 If we build with older GTK+, the build fails: Presumabl

Re: [PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later

2020-01-16 Thread Daniel P . Berrangé
On Thu, Jan 16, 2020 at 02:12:17AM +0100, Philippe Mathieu-Daudé wrote: > The GdkMonitor was introduced in GTK+ 3.22: > https://developer.gnome.org/gdk3/stable/api-index-3-22.html#api-index-3.22 > > If we build with older GTK+, the build fails: Presumably the problem here is Ubuntu Xenial 16.04 w

Re: [PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later

2020-01-16 Thread Gerd Hoffmann
Hi, > Fixes: c4c00922cc (display/gtk: get proper refreshrate) > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Gerd Hoffmann > --- > Sorry I missed that, I only tested Nikola's patch on my workstation > which runs Fedora 30: > > $ pkg-config --modversion gtk+-3.0 > 3.24.11 Even RHE

[PATCH] ui/gtk: Get display refresh rate with GDK version 3.22 or later

2020-01-15 Thread Philippe Mathieu-Daudé
The GdkMonitor was introduced in GTK+ 3.22: https://developer.gnome.org/gdk3/stable/api-index-3-22.html#api-index-3.22 If we build with older GTK+, the build fails: CC ui/gtk.o qemu/ui/gtk.c: In function ‘gd_vc_gfx_init’: qemu/ui/gtk.c:1973:5: error: unknown type name ‘GdkMonitor’