Re: [PATCH] ui/dbus: implement damage regions for GL

2023-08-14 Thread Bilal Elmoussaoui
Thanks for the quick review! I have sent a v2 with the requested changes. On Mon, Aug 14, 2023 at 2:41 PM Marc-André Lureau < marcandre.lur...@gmail.com> wrote: > Hi > > On Mon, Aug 14, 2023 at 4:10 PM Bilal Elmoussaoui > wrote: > > > > Currently, when using `-display dbus,gl=on` all updates to

Re: [PATCH] ui/dbus: implement damage regions for GL

2023-08-14 Thread Marc-André Lureau
Hi On Mon, Aug 14, 2023 at 4:10 PM Bilal Elmoussaoui wrote: > > Currently, when using `-display dbus,gl=on` all updates to the client > become "full scanout" updates, meaning there is no way for the client to > limit damage regions to the display server. > > Instead of using an "update count", th

[PATCH] ui/dbus: implement damage regions for GL

2023-08-14 Thread Bilal Elmoussaoui
Currently, when using `-display dbus,gl=on` all updates to the client become "full scanout" updates, meaning there is no way for the client to limit damage regions to the display server. Instead of using an "update count", this patch tracks the damage region and propagates it to the client. This

Re: [PATCH] ui/dbus: Implement damage regions for GL

2023-05-09 Thread Philippe Mathieu-Daudé
On 9/5/23 17:04, Bilal Elmoussaoui wrote: cairo declared as optional dep, ... I don't see where cairo is marked as an optional dependency, the `cairo = not_found` part could probably be dropped to make it clearer. I was expecting: .require(cairo.found(), error_message: '-display dbus re

Re: [PATCH] ui/dbus: Implement damage regions for GL

2023-05-09 Thread Bilal Elmoussaoui
> > cairo declared as optional dep, ... > I don't see where cairo is marked as an optional dependency, the `cairo = not_found` part could probably be dropped to make it clearer. On Tue, May 9, 2023 at 4:34 PM Philippe Mathieu-Daudé wrote: > Hi, > > On 9/5/23 13:59, Bilal Elmoussaoui wrote: > >

Re: [PATCH] ui/dbus: Implement damage regions for GL

2023-05-09 Thread Philippe Mathieu-Daudé
Hi, On 9/5/23 13:59, Bilal Elmoussaoui wrote: From: Christian Hergert Currently, when using `-display dbus,gl=on` all updates to the client become "full scanout" updates, meaning there is no way for the client to limit damage regions to the display server. Instead of using an "update count",

[PATCH] ui/dbus: Implement damage regions for GL

2023-05-09 Thread Bilal Elmoussaoui
From: Christian Hergert Currently, when using `-display dbus,gl=on` all updates to the client become "full scanout" updates, meaning there is no way for the client to limit damage regions to the display server. Instead of using an "update count", this patch tracks the damage region and propagate