Re: [PATCH] ui/cocoa: Fix switched_to_fullscreen warning

2022-07-12 Thread Philippe Mathieu-Daudé via
On 2/7/22 06:43, Peter Delevoryas wrote: I noticed this error while building QEMU on Mac OS X: [1040/1660] Compiling Objective-C object libcommon.fa.p/ui_cocoa.m.o ../ui/cocoa.m:803:17: warning: variable 'switched_to_fullscreen' set but not used [-Wunused-but-set-variable] st

Re: [PATCH] ui/cocoa: Fix switched_to_fullscreen warning

2022-07-11 Thread Akihiko Odaki
On 2022/07/12 9:05, Peter Delevoryas wrote: On Wed, Jul 06, 2022 at 05:58:38PM -0700, Peter Delevoryas wrote: On Sat, Jul 02, 2022 at 11:30:16PM +0900, Akihiko Odaki wrote: Reviewed-by: Akihiko Odaki Just checking in on the status of this: do I need to submit a pull request? Or will this pat

Re: [PATCH] ui/cocoa: Fix switched_to_fullscreen warning

2022-07-11 Thread Peter Delevoryas
On Wed, Jul 06, 2022 at 05:58:38PM -0700, Peter Delevoryas wrote: > On Sat, Jul 02, 2022 at 11:30:16PM +0900, Akihiko Odaki wrote: > > Reviewed-by: Akihiko Odaki > > Just checking in on the status of this: do I need to submit a pull request? > Or will this patch be picked up in a miscellaneous pu

Re: [PATCH] ui/cocoa: Fix switched_to_fullscreen warning

2022-07-06 Thread Peter Delevoryas
On Sat, Jul 02, 2022 at 11:30:16PM +0900, Akihiko Odaki wrote: > Reviewed-by: Akihiko Odaki Just checking in on the status of this: do I need to submit a pull request? Or will this patch be picked up in a miscellaneous pull queue eventually? > > On 2022/07/02 13:43, Peter Delevoryas wrote: > >

Re: [PATCH] ui/cocoa: Fix switched_to_fullscreen warning

2022-07-02 Thread Akihiko Odaki
Reviewed-by: Akihiko Odaki On 2022/07/02 13:43, Peter Delevoryas wrote: I noticed this error while building QEMU on Mac OS X: [1040/1660] Compiling Objective-C object libcommon.fa.p/ui_cocoa.m.o ../ui/cocoa.m:803:17: warning: variable 'switched_to_fullscreen' set but not used [-Wunu

[PATCH] ui/cocoa: Fix switched_to_fullscreen warning

2022-07-01 Thread Peter Delevoryas
I noticed this error while building QEMU on Mac OS X: [1040/1660] Compiling Objective-C object libcommon.fa.p/ui_cocoa.m.o ../ui/cocoa.m:803:17: warning: variable 'switched_to_fullscreen' set but not used [-Wunused-but-set-variable] static bool switched_to_fullscreen = false;