Re: [PATCH] ui/cocoa: Fix incorrect window clipping on macOS Sonoma

2024-02-23 Thread BALATON Zoltan
On Fri, 23 Feb 2024, David Parsons wrote: Hi Akihiko I’ve re-worked the patch to match your suggestion. I have compiled and tested it on Sonoma and Monterey and both builds worked correctly. New patch is below. I’m new to sending patches to QEMU so please let me know if I need to do anything el

Re: [PATCH] ui/cocoa: Fix incorrect window clipping on macOS Sonoma

2024-02-23 Thread David Parsons
Hi Akihiko I’ve re-worked the patch to match your suggestion. I have compiled and tested it on Sonoma and Monterey and both builds worked correctly. New patch is below. I’m new to sending patches to QEMU so please let me know if I need to do anything else to get it incorporated into the repo. D

Re: [PATCH] ui/cocoa: Fix incorrect window clipping on macOS Sonoma

2024-02-23 Thread Akihiko Odaki
On 2024/02/23 2:10, Peter Maydell wrote: On Thu, 22 Feb 2024 at 06:08, Michael Tokarev wrote: [Adding a few more Ccs] 17.02.2024 18:58, David Parsons : macOS Sonoma changes the NSView.clipsToBounds to false by default where it was true in earlier version of macOS. This causes the window con

Re: [PATCH] ui/cocoa: Fix incorrect window clipping on macOS Sonoma

2024-02-22 Thread Peter Maydell
On Thu, 22 Feb 2024 at 06:08, Michael Tokarev wrote: > > [Adding a few more Ccs] > > 17.02.2024 18:58, David Parsons : > > macOS Sonoma changes the NSView.clipsToBounds to false by default where it > > was true in > > earlier version of macOS. This causes the window contents to be obscured by >

Re: [PATCH] ui/cocoa: Fix incorrect window clipping on macOS Sonoma

2024-02-21 Thread Michael Tokarev
[Adding a few more Ccs] 17.02.2024 18:58, David Parsons : macOS Sonoma changes the NSView.clipsToBounds to false by default where it was true in earlier version of macOS. This causes the window contents to be obscured by the window frame. This fixes the issue by conditionally setting the clipp

[PATCH] ui/cocoa: Fix incorrect window clipping on macOS Sonoma

2024-02-17 Thread David Parsons
macOS Sonoma changes the NSView.clipsToBounds to false by default where it was true in earlier version of macOS. This causes the window contents to be obscured by the window frame. This fixes the issue by conditionally setting the clipping on Sonoma to true. Resolves: https://gitlab.com/qemu-pr