Applied to my tracing tree, thanks!
https://gitlab.com/stefanha/qemu/-/commit/ffcfb0faaa95fc6ca007f7dd989e390dacf936ca
Stefan
I have shared v2 with updated commit msg to everyone in form of a new PATCH.
Please check it and let me know if anything is still missing or confusing.
On Wed, 28 May 2025 at 11:36 PM, Stefan Hajnoczi wrote:
> On Mon, May 26, 2025 at 10:51 PM Tanish Desai
> wrote:
> >
> > > Can you explain 3 m
This change improves performance by moving the hot path of the
trace_vhost_commit()(or any other trace function) logic to the header file.
Previously, even when the trace event was disabled, the function call chain:-
trace_vhost_commit()(Or any other trace function) →
_nocheck__trace_vho
On Mon, May 26, 2025 at 10:51 PM Tanish Desai wrote:
>
> > Can you explain 3 more?
> Pablo and I have looked into object files for one of default trace point
> "trace_vhost_commit"(first tracepoint of hw/virtio) before and after making
> this change and we found that by moves the hot-path check
> Can you explain 3 more?
Pablo and I have looked into object files for one of default trace point "
trace_vhost_commit"(first tracepoint of hw/virtio) before and after making
this change and we found that by moves the hot-path check for
_simple_trace_vhost_commit into the caller (in the .h file) a
On Tue, May 20, 2025 at 4:52 PM Paolo Bonzini wrote:
> Il mar 20 mag 2025, 21:01 Stefan Hajnoczi ha scritto:
>>
>> On Mon, May 19, 2025 at 2:52 PM Tanish Desai wrote:
>> >
>> > Remove hot paths from .c file and added it in .h file to keep it inline.
>>
>> Please include performance results in th
Il mar 20 mag 2025, 21:01 Stefan Hajnoczi ha scritto:
> On Mon, May 19, 2025 at 2:52 PM Tanish Desai
> wrote:
> >
> > Remove hot paths from .c file and added it in .h file to keep it inline.
>
> Please include performance results in the commit description so it's
> clear what impact this change
On Mon, May 19, 2025 at 2:52 PM Tanish Desai wrote:
>
> Remove hot paths from .c file and added it in .h file to keep it inline.
Please include performance results in the commit description so it's
clear what impact this change has.
>
> Signed-off-by: Tanish Desai
> ---
> scripts/tracetool/bac
Remove hot paths from .c file and added it in .h file to keep it inline.
Signed-off-by: Tanish Desai
---
scripts/tracetool/backend/simple.py | 23 ++-
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/scripts/tracetool/backend/simple.py
b/scripts/tracetool/back
