Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio

2021-01-06 Thread Thomas Huth
On 05/01/2021 13.44, Alex Bennée wrote: The read binary data as text via a PPM export of the frame buffer seems a bit sketchy and it did blow up in the real world when the assertion failed: https://gitlab.com/qemu-project/qemu/-/jobs/943183183 However short of cleaning up the test to be more

Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio

2021-01-05 Thread Halil Pasic
On Tue, 5 Jan 2021 12:44:05 + Alex Bennée wrote: > The read binary data as text via a PPM export of the frame buffer > seems a bit sketchy and it did blow up in the real world when the > assertion failed: > > https://gitlab.com/qemu-project/qemu/-/jobs/943183183 > > However short of clea

Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio

2021-01-05 Thread Willian Rampazzo
On Tue, Jan 5, 2021 at 9:46 AM Alex Bennée wrote: > > The read binary data as text via a PPM export of the frame buffer > seems a bit sketchy and it did blow up in the real world when the > assertion failed: > > https://gitlab.com/qemu-project/qemu/-/jobs/943183183 > > However short of cleaning

Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio

2021-01-05 Thread Daniel P . Berrangé
On Tue, Jan 05, 2021 at 12:44:05PM +, Alex Bennée wrote: > The read binary data as text via a PPM export of the frame buffer > seems a bit sketchy and it did blow up in the real world when the > assertion failed: > > https://gitlab.com/qemu-project/qemu/-/jobs/943183183 > > However short of

[PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio

2021-01-05 Thread Alex Bennée
The read binary data as text via a PPM export of the frame buffer seems a bit sketchy and it did blow up in the real world when the assertion failed: https://gitlab.com/qemu-project/qemu/-/jobs/943183183 However short of cleaning up the test to be more binary focused at least limit the attempt