Re: [PATCH] test-vmstate: fix bad GTree usage, use-after-free

2020-08-28 Thread Auger Eric
Hi Marc-André, On 8/28/20 9:19 AM, Auger Eric wrote: > Hi Marc-André, > > On 8/27/20 8:35 PM, Marc-André Lureau wrote: >> Hi >> >> On Thu, Aug 27, 2020 at 8:34 PM Auger Eric > > wrote: >> >> Hi Marc-Andre >> >> On 8/27/20 6:18 PM, marcandre.lur...@redhat.com

Re: [PATCH] test-vmstate: fix bad GTree usage, use-after-free

2020-08-28 Thread Auger Eric
Hi Marc-André, On 8/27/20 8:35 PM, Marc-André Lureau wrote: > Hi > > On Thu, Aug 27, 2020 at 8:34 PM Auger Eric > wrote: > > Hi Marc-Andre > > On 8/27/20 6:18 PM, marcandre.lur...@redhat.com > wrote: > > From: M

Re: [PATCH] test-vmstate: fix bad GTree usage, use-after-free

2020-08-27 Thread Marc-André Lureau
Hi On Thu, Aug 27, 2020 at 8:34 PM Auger Eric wrote: > Hi Marc-Andre > > On 8/27/20 6:18 PM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > According to g_tree_foreach() documentation: > > "The tree may not be modified while iterating over it (you can't > > add/remove it

Re: [PATCH] test-vmstate: fix bad GTree usage, use-after-free

2020-08-27 Thread Auger Eric
Hi Marc-Andre On 8/27/20 6:18 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > According to g_tree_foreach() documentation: > "The tree may not be modified while iterating over it (you can't > add/remove items)." Hum I did not see that. > > Fixes: 9a85e4b8f6 ("migration: Su

Re: [PATCH] test-vmstate: fix bad GTree usage, use-after-free

2020-08-27 Thread Juan Quintela
marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > According to g_tree_foreach() documentation: > "The tree may not be modified while iterating over it (you can't > add/remove items)." > > Fixes: 9a85e4b8f6 ("migration: Support gtree migration") > Cc: Eric Auger > Signed-off-by: Mar

[PATCH] test-vmstate: fix bad GTree usage, use-after-free

2020-08-27 Thread marcandre . lureau
From: Marc-André Lureau According to g_tree_foreach() documentation: "The tree may not be modified while iterating over it (you can't add/remove items)." Fixes: 9a85e4b8f6 ("migration: Support gtree migration") Cc: Eric Auger Signed-off-by: Marc-André Lureau --- tests/test-vmstate.c | 3 +--