Re: [PATCH] tcg: gdbstub: Fix missing breakpoint issue

2020-02-05 Thread Changbin Du
On Wed, Feb 05, 2020 at 11:03:23AM +, Richard Henderson wrote: > On 1/24/20 2:17 AM, Changbin Du wrote: > > When inserting breakpoints, we need to invalidate related TBs to apply > > helper call. This is done by breakpoint_invalidate(). But many users > > found the BPs sometimes never hit. > >

Re: [PATCH] tcg: gdbstub: Fix missing breakpoint issue

2020-02-05 Thread Richard Henderson
On 1/24/20 2:17 AM, Changbin Du wrote: > When inserting breakpoints, we need to invalidate related TBs to apply > helper call. This is done by breakpoint_invalidate(). But many users > found the BPs sometimes never hit. > > In system mode emulation, the BPs are global in guest but not particular >

Re: [PATCH] tcg: gdbstub: Fix missing breakpoint issue

2020-02-03 Thread Changbin Du
Hello, Any review? Thanks! On Fri, Jan 24, 2020 at 10:17:28AM +0800, Changbin Du wrote: > When inserting breakpoints, we need to invalidate related TBs to apply > helper call. This is done by breakpoint_invalidate(). But many users > found the BPs sometimes never hit. > > In system mode emulation

[PATCH] tcg: gdbstub: Fix missing breakpoint issue

2020-01-23 Thread Changbin Du
When inserting breakpoints, we need to invalidate related TBs to apply helper call. This is done by breakpoint_invalidate(). But many users found the BPs sometimes never hit. In system mode emulation, the BPs are global in guest but not particular address space. The issue is that the current imple