Re: [PATCH] tcg: Increase the static number of temporaries

2021-01-25 Thread Laurent Vivier
Le 25/01/2021 à 10:31, Alex Bennée a écrit : > > Laurent Vivier writes: > >> Le 23/01/2021 à 17:19, Laurent Vivier a écrit : >>> Le 21/01/2021 à 03:54, Richard Henderson a écrit : This isn't a total or permanent solution to the problem of running out of temporaries, but it puts off the

Re: [PATCH] tcg: Increase the static number of temporaries

2021-01-25 Thread Alex Bennée
Laurent Vivier writes: > Le 23/01/2021 à 17:19, Laurent Vivier a écrit : >> Le 21/01/2021 à 03:54, Richard Henderson a écrit : >>> This isn't a total or permanent solution to the problem of running >>> out of temporaries, but it puts off the issue for a bit. >>> >>> Make the assert in tcg_temp_

Re: [PATCH] tcg: Increase the static number of temporaries

2021-01-23 Thread Richard Henderson
On 1/23/21 9:36 AM, Laurent Vivier wrote: >>> -#define TCG_MAX_TEMPS 512 >>> +#define TCG_MAX_TEMPS 1024 >> >> This seems not enough, I have: >> >> ERROR:.../tcg/tcg.c:1210:tcg_temp_alloc: assertion failed: (n < >> TCG_MAX_TEMPS) >> Bail out! ERROR:.../tcg/tcg.c:1210:tcg_temp_alloc: assertion fail

Re: [PATCH] tcg: Increase the static number of temporaries

2021-01-23 Thread Laurent Vivier
Le 23/01/2021 à 17:19, Laurent Vivier a écrit : > Le 21/01/2021 à 03:54, Richard Henderson a écrit : >> This isn't a total or permanent solution to the problem of running >> out of temporaries, but it puts off the issue for a bit. >> >> Make the assert in tcg_temp_alloc unconditional. If we do run

Re: [PATCH] tcg: Increase the static number of temporaries

2021-01-23 Thread Laurent Vivier
Le 21/01/2021 à 03:54, Richard Henderson a écrit : > This isn't a total or permanent solution to the problem of running > out of temporaries, but it puts off the issue for a bit. > > Make the assert in tcg_temp_alloc unconditional. If we do run out > of temps, this can fail much later as a weird

Re: [PATCH] tcg: Increase the static number of temporaries

2021-01-21 Thread Alex Bennée
Richard Henderson writes: > This isn't a total or permanent solution to the problem of running > out of temporaries, but it puts off the issue for a bit. > > Make the assert in tcg_temp_alloc unconditional. If we do run out > of temps, this can fail much later as a weird SIGSEGV, due to the >

Re: [PATCH] tcg: Increase the static number of temporaries

2021-01-20 Thread Philippe Mathieu-Daudé
On 1/21/21 3:54 AM, Richard Henderson wrote: > This isn't a total or permanent solution to the problem of running > out of temporaries, but it puts off the issue for a bit. > > Make the assert in tcg_temp_alloc unconditional. If we do run out > of temps, this can fail much later as a weird SIGSEG

[PATCH] tcg: Increase the static number of temporaries

2021-01-20 Thread Richard Henderson
This isn't a total or permanent solution to the problem of running out of temporaries, but it puts off the issue for a bit. Make the assert in tcg_temp_alloc unconditional. If we do run out of temps, this can fail much later as a weird SIGSEGV, due to the buffer overrun of the temp array. Remove