Re: [PATCH] tcg/s390x: fix constraint for 32-bit TSTEQ/TSTNE

2024-10-17 Thread Philippe Mathieu-Daudé
On 17/10/24 06:14, Paolo Bonzini wrote: 32-bit TSTEQ and TSTNE is subject to the same constraints as for 64-bit, but setcond_i32 and negsetcond_i32 were incorrectly using TCG_CT_CONST ("i") instead of TCG_CT_CONST_CMP ("C"). Adjust the constraint and make tcg_target_const_match use the same sequ

Re: [PATCH] tcg/s390x: fix constraint for 32-bit TSTEQ/TSTNE

2024-10-17 Thread Richard Henderson
On 10/17/24 02:14, Paolo Bonzini wrote: 32-bit TSTEQ and TSTNE is subject to the same constraints as for 64-bit, but setcond_i32 and negsetcond_i32 were incorrectly using TCG_CT_CONST ("i") instead of TCG_CT_CONST_CMP ("C"). Adjust the constraint and make tcg_target_const_match use the same sequ

Re: [PATCH] tcg/s390x: fix constraint for 32-bit TSTEQ/TSTNE

2024-10-17 Thread Paolo Bonzini
On 10/17/24 12:00, Peter Maydell wrote: On Thu, 17 Oct 2024 at 10:14, Paolo Bonzini wrote: 32-bit TSTEQ and TSTNE is subject to the same constraints as for 64-bit, but setcond_i32 and negsetcond_i32 were incorrectly using TCG_CT_CONST ("i") instead of TCG_CT_CONST_CMP ("C"). Adjust the constr

Re: [PATCH] tcg/s390x: fix constraint for 32-bit TSTEQ/TSTNE

2024-10-17 Thread Peter Maydell
On Thu, 17 Oct 2024 at 10:14, Paolo Bonzini wrote: > > 32-bit TSTEQ and TSTNE is subject to the same constraints as > for 64-bit, but setcond_i32 and negsetcond_i32 were incorrectly > using TCG_CT_CONST ("i") instead of TCG_CT_CONST_CMP ("C"). > > Adjust the constraint and make tcg_target_const_ma

[PATCH] tcg/s390x: fix constraint for 32-bit TSTEQ/TSTNE

2024-10-17 Thread Paolo Bonzini
32-bit TSTEQ and TSTNE is subject to the same constraints as for 64-bit, but setcond_i32 and negsetcond_i32 were incorrectly using TCG_CT_CONST ("i") instead of TCG_CT_CONST_CMP ("C"). Adjust the constraint and make tcg_target_const_match use the same sequence as tgen_cmp2: first check if the cons