Re: [PATCH] tcg/perf: Placate clang-21's -Wdefault-const-init-field-unsafe

2025-05-24 Thread Richard Henderson
On 5/19/25 22:48, Ilya Leoshkevich wrote: diff --git a/tcg/perf.c b/tcg/perf.c index 4e8d2c1bee7..f30c5b489d1 100644 --- a/tcg/perf.c +++ b/tcg/perf.c @@ -154,7 +154,7 @@ struct debug_entry { uint64_t addr; int lineno; int discrim; -const char name[]; +char name[]; };

Re: [PATCH] tcg/perf: Placate clang-21's -Wdefault-const-init-field-unsafe

2025-05-20 Thread Peter Maydell
On Mon, 19 May 2025 at 22:49, Ilya Leoshkevich wrote: > > clang-21 complains about the const "name" field in struct debug_entry. > While this warning may be too aggressive, there is not too much value > in having const there, so just drop it. It looks like this warning is only emitted by git-trun

[PATCH] tcg/perf: Placate clang-21's -Wdefault-const-init-field-unsafe

2025-05-19 Thread Ilya Leoshkevich
clang-21 complains about the const "name" field in struct debug_entry. While this warning may be too aggressive, there is not too much value in having const there, so just drop it. Note: in addition to this fix, I had to turn off the following clang-21 warnings to make the build work: * -Wno-pare