RE: [PATCH] tcg/optimize: Add fallthrough annotations

2020-10-29 Thread Chenqun (kuhn)
> -Original Message- > From: Richard Henderson [mailto:richard.hender...@linaro.org] > Sent: Friday, October 30, 2020 4:07 AM > To: Thomas Huth ; Richard Henderson ; > qemu-devel@nongnu.org > Cc: Chenqun (kuhn) > Subject: Re: [PATCH] tcg/optimize: Add fallthrough anno

Re: [PATCH] tcg/optimize: Add fallthrough annotations

2020-10-29 Thread Richard Henderson
On 10/29/20 5:28 AM, Thomas Huth wrote: > To be able to compile this file with -Werror=implicit-fallthrough, > we need to add some fallthrough annotations to the case statements > that might fall through. Unfortunately, the typical "/* fallthrough */" > comments do not work here as expected since s

Re: [PATCH] tcg/optimize: Add fallthrough annotations

2020-10-29 Thread Philippe Mathieu-Daudé
On 10/29/20 1:28 PM, Thomas Huth wrote: > To be able to compile this file with -Werror=implicit-fallthrough, > we need to add some fallthrough annotations to the case statements > that might fall through. Unfortunately, the typical "/* fallthrough */" > comments do not work here as expected since s

[PATCH] tcg/optimize: Add fallthrough annotations

2020-10-29 Thread Thomas Huth
To be able to compile this file with -Werror=implicit-fallthrough, we need to add some fallthrough annotations to the case statements that might fall through. Unfortunately, the typical "/* fallthrough */" comments do not work here as expected since some case labels are wrapped in macros and the co