Re: [PATCH] target/riscv: Set opcode to env->bins for illegal/virtual instruction fault

2023-04-04 Thread Alistair Francis
On Thu, Mar 30, 2023 at 1:47 PM Weiwei Li wrote: > > decode_save_opc() will not work for generate_exception(), since 0 is passed > to riscv_raise_exception() as pc in helper_raise_exception(), and bins will > not be restored in this case. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wan

Re: [PATCH] target/riscv: Set opcode to env->bins for illegal/virtual instruction fault

2023-04-04 Thread Alistair Francis
On Thu, Mar 30, 2023 at 1:47 PM Weiwei Li wrote: > > decode_save_opc() will not work for generate_exception(), since 0 is passed > to riscv_raise_exception() as pc in helper_raise_exception(), and bins will > not be restored in this case. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wan

Re: [PATCH] target/riscv: Set opcode to env->bins for illegal/virtual instruction fault

2023-03-30 Thread Daniel Henrique Barboza
On 3/30/23 00:46, Weiwei Li wrote: decode_save_opc() will not work for generate_exception(), since 0 is passed to riscv_raise_exception() as pc in helper_raise_exception(), and bins will not be restored in this case. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- Reviewed-by: D

[PATCH] target/riscv: Set opcode to env->bins for illegal/virtual instruction fault

2023-03-29 Thread Weiwei Li
decode_save_opc() will not work for generate_exception(), since 0 is passed to riscv_raise_exception() as pc in helper_raise_exception(), and bins will not be restored in this case. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/insn_trans/trans_rvh.c.inc | 2 ++ 1 file