Re: [PATCH] target/riscv: Fix satp write

2021-09-05 Thread LIU Zhiwei
On 2021/9/6 上午11:26, Bin Meng wrote: On Mon, Sep 6, 2021 at 11:23 AM LIU Zhiwei wrote: On 2021/9/2 上午10:47, Bin Meng wrote: On Thu, Sep 2, 2021 at 10:44 AM LIU Zhiwei wrote: On 2021/9/2 上午9:59, Bin Meng wrote: On Thu, Sep 2, 2021 at 9:02 AM LIU Zhiwei wrote: On 2021/9/1 下午9:05, Bin Men

Re: [PATCH] target/riscv: Fix satp write

2021-09-05 Thread Alistair Francis
On Wed, Sep 1, 2021 at 10:51 PM LIU Zhiwei wrote: > > These variables should be target_ulong. If truncated to int, > the bool conditions they indicate will be wrong. > > As satp is very important for Linux, this bug almost fails every boot. > > Signed-off-by: LIU Zhiwei Thanks! Applied to riscv

Re: [PATCH] target/riscv: Fix satp write

2021-09-05 Thread Bin Meng
On Mon, Sep 6, 2021 at 11:23 AM LIU Zhiwei wrote: > > > On 2021/9/2 上午10:47, Bin Meng wrote: > > On Thu, Sep 2, 2021 at 10:44 AM LIU Zhiwei wrote: > >> > >> On 2021/9/2 上午9:59, Bin Meng wrote: > >>> On Thu, Sep 2, 2021 at 9:02 AM LIU Zhiwei wrote: > On 2021/9/1 下午9:05, Bin Meng wrote: > >>>

Re: [PATCH] target/riscv: Fix satp write

2021-09-05 Thread LIU Zhiwei
On 2021/9/2 上午10:47, Bin Meng wrote: On Thu, Sep 2, 2021 at 10:44 AM LIU Zhiwei wrote: On 2021/9/2 上午9:59, Bin Meng wrote: On Thu, Sep 2, 2021 at 9:02 AM LIU Zhiwei wrote: On 2021/9/1 下午9:05, Bin Meng wrote: On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote: These variables should be tar

Re: [PATCH] target/riscv: Fix satp write

2021-09-01 Thread Alistair Francis
On Thu, Sep 2, 2021 at 11:59 AM Bin Meng wrote: > > On Thu, Sep 2, 2021 at 9:02 AM LIU Zhiwei wrote: > > > > > > On 2021/9/1 下午9:05, Bin Meng wrote: > > > On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote: > > >> These variables should be target_ulong. If truncated to int, > > >> the bool conditio

Re: [PATCH] target/riscv: Fix satp write

2021-09-01 Thread Bin Meng
On Thu, Sep 2, 2021 at 10:44 AM LIU Zhiwei wrote: > > > On 2021/9/2 上午9:59, Bin Meng wrote: > > On Thu, Sep 2, 2021 at 9:02 AM LIU Zhiwei wrote: > >> > >> On 2021/9/1 下午9:05, Bin Meng wrote: > >>> On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote: > These variables should be target_ulong. If

Re: [PATCH] target/riscv: Fix satp write

2021-09-01 Thread LIU Zhiwei
On 2021/9/2 上午9:59, Bin Meng wrote: On Thu, Sep 2, 2021 at 9:02 AM LIU Zhiwei wrote: On 2021/9/1 下午9:05, Bin Meng wrote: On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote: These variables should be target_ulong. If truncated to int, the bool conditions they indicate will be wrong. As satp

Re: [PATCH] target/riscv: Fix satp write

2021-09-01 Thread Bin Meng
On Thu, Sep 2, 2021 at 9:02 AM LIU Zhiwei wrote: > > > On 2021/9/1 下午9:05, Bin Meng wrote: > > On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote: > >> These variables should be target_ulong. If truncated to int, > >> the bool conditions they indicate will be wrong. > >> > >> As satp is very importa

Re: [PATCH] target/riscv: Fix satp write

2021-09-01 Thread LIU Zhiwei
On 2021/9/1 下午9:05, Bin Meng wrote: On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote: These variables should be target_ulong. If truncated to int, the bool conditions they indicate will be wrong. As satp is very important for Linux, this bug almost fails every boot. Could you please describe

Re: [PATCH] target/riscv: Fix satp write

2021-09-01 Thread Bin Meng
On Wed, Sep 1, 2021 at 8:51 PM LIU Zhiwei wrote: > > These variables should be target_ulong. If truncated to int, > the bool conditions they indicate will be wrong. > > As satp is very important for Linux, this bug almost fails every boot. Could you please describe which Linux configuration is br

[PATCH] target/riscv: Fix satp write

2021-09-01 Thread LIU Zhiwei
These variables should be target_ulong. If truncated to int, the bool conditions they indicate will be wrong. As satp is very important for Linux, this bug almost fails every boot. Signed-off-by: LIU Zhiwei --- target/riscv/csr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git