Re: [PATCH] target/ppc: fix setting of CR flags in bcdcfsq

2021-09-05 Thread David Gibson
On Mon, Aug 23, 2021 at 12:02:35PM -0300, Luis Pires wrote: > According to the ISA, CR should be set based on the source value, and > not on the packed decimal result. > The way this was implemented would cause GT, LT and EQ to be set > incorrectly when the source value was too large and the 31 lea

Re: [PATCH] target/ppc: fix setting of CR flags in bcdcfsq

2021-09-05 Thread Richard Henderson
On 8/23/21 5:02 PM, Luis Pires wrote: According to the ISA, CR should be set based on the source value, and not on the packed decimal result. The way this was implemented would cause GT, LT and EQ to be set incorrectly when the source value was too large and the 31 least significant digits of the

Re: [PATCH] target/ppc: fix setting of CR flags in bcdcfsq

2021-08-24 Thread David Gibson
On Mon, Aug 23, 2021 at 12:02:35PM -0300, Luis Pires wrote: > According to the ISA, CR should be set based on the source value, and > not on the packed decimal result. > The way this was implemented would cause GT, LT and EQ to be set > incorrectly when the source value was too large and the 31 lea

[PATCH] target/ppc: fix setting of CR flags in bcdcfsq

2021-08-23 Thread Luis Pires
According to the ISA, CR should be set based on the source value, and not on the packed decimal result. The way this was implemented would cause GT, LT and EQ to be set incorrectly when the source value was too large and the 31 least significant digits of the packed decimal result ended up being al