Re: [PATCH] target/ppc: Fix TCG leak with the evmwsmiaa instruction

2020-07-27 Thread David Gibson
On Mon, Jul 27, 2020 at 10:21:14AM -0700, Matthieu Bucchianeri wrote: > Fix double-call to tcg_temp_new_i64(), where a temp is allocated both at > declaration time and further down the implementation of gen_evmwsmiaa(). > > Note that gen_evmwsmia() and gen_evmwsmiaa() are still not implemented > c

Re: [PATCH] target/ppc: Fix TCG leak with the evmwsmiaa instruction

2020-07-27 Thread Richard Henderson
On 7/27/20 10:21 AM, Matthieu Bucchianeri wrote: > Fix double-call to tcg_temp_new_i64(), where a temp is allocated both at > declaration time and further down the implementation of gen_evmwsmiaa(). > > Note that gen_evmwsmia() and gen_evmwsmiaa() are still not implemented > correctly, as they inv

[PATCH] target/ppc: Fix TCG leak with the evmwsmiaa instruction

2020-07-27 Thread Matthieu Bucchianeri
Fix double-call to tcg_temp_new_i64(), where a temp is allocated both at declaration time and further down the implementation of gen_evmwsmiaa(). Note that gen_evmwsmia() and gen_evmwsmiaa() are still not implemented correctly, as they invoke gen_evmwsmi() which may return early, but the return is