Re: [PATCH] target/ppc: BHRB avoid using host pointer in translated code

2024-02-27 Thread Miles Glenn
On Tue, 2024-02-20 at 10:35 +1000, Nicholas Piggin wrote: > On Fri Feb 16, 2024 at 3:50 AM AEST, Peter Maydell wrote: > > On Thu, 15 Feb 2024 at 17:16, Nicholas Piggin > > wrote: > > > Calculate the BHRB base from arithmetic on the tcg_env target > > > ptr. > > > > > > Signed-off-by: Nicholas Pig

Re: [PATCH] target/ppc: BHRB avoid using host pointer in translated code

2024-02-19 Thread Nicholas Piggin
On Fri Feb 16, 2024 at 3:50 AM AEST, Peter Maydell wrote: > On Thu, 15 Feb 2024 at 17:16, Nicholas Piggin wrote: > > > > Calculate the BHRB base from arithmetic on the tcg_env target ptr. > > > > Signed-off-by: Nicholas Piggin > > --- > > Hi Glenn, > > > > I think I have to squash this into the B

Re: [PATCH] target/ppc: BHRB avoid using host pointer in translated code

2024-02-19 Thread Nicholas Piggin
On Fri Feb 16, 2024 at 5:42 AM AEST, Richard Henderson wrote: > On 2/15/24 07:15, Nicholas Piggin wrote: > > diff --git a/target/ppc/machine.c b/target/ppc/machine.c > > index 731dd8df35..3541cd83cd 100644 > > --- a/target/ppc/machine.c > > +++ b/target/ppc/machine.c > > @@ -724,7 +724,7 @@ static

Re: [PATCH] target/ppc: BHRB avoid using host pointer in translated code

2024-02-15 Thread Richard Henderson
On 2/15/24 07:15, Nicholas Piggin wrote: diff --git a/target/ppc/machine.c b/target/ppc/machine.c index 731dd8df35..3541cd83cd 100644 --- a/target/ppc/machine.c +++ b/target/ppc/machine.c @@ -724,7 +724,7 @@ static const VMStateDescription vmstate_bhrb = { .minimum_version_id = 1, .ne

Re: [PATCH] target/ppc: BHRB avoid using host pointer in translated code

2024-02-15 Thread Peter Maydell
On Thu, 15 Feb 2024 at 17:16, Nicholas Piggin wrote: > > Calculate the BHRB base from arithmetic on the tcg_env target ptr. > > Signed-off-by: Nicholas Piggin > --- > Hi Glenn, > > I think I have to squash this into the BHRB series. 32-bit host > compile shows up a size mismatch warning... I thin

[PATCH] target/ppc: BHRB avoid using host pointer in translated code

2024-02-15 Thread Nicholas Piggin
Calculate the BHRB base from arithmetic on the tcg_env target ptr. Signed-off-by: Nicholas Piggin --- Hi Glenn, I think I have to squash this into the BHRB series. 32-bit host compile shows up a size mismatch warning... I think it's not quite right to be using host pointer directly in target cod