Re: [PATCH] target/loongarch: Split fcc register to fcc0-7 in gdbstub

2023-08-18 Thread gaosong
Hi, Alex 在 2023/8/9 上午2:40, Alex Bennée 写道: bibo mao writes: I think that it is problem of loongarch gdb, rather qemu. If so, everytime when gdb changes register layout, qemu need modify. There should be compatible requirements between gdb client and gdb server. Tiezhu, what is your opitio

Re: [PATCH] target/loongarch: Split fcc register to fcc0-7 in gdbstub

2023-08-08 Thread Alex Bennée
bibo mao writes: > I think that it is problem of loongarch gdb, rather qemu. > If so, everytime when gdb changes register layout, qemu need modify. > There should be compatible requirements between gdb client and gdb server. > > Tiezhu, > > what is your opition? You can always register additio

Re: [PATCH] target/loongarch: Split fcc register to fcc0-7 in gdbstub

2023-08-08 Thread bibo mao
I think that it is problem of loongarch gdb, rather qemu. If so, everytime when gdb changes register layout, qemu need modify. There should be compatible requirements between gdb client and gdb server. Tiezhu, what is your opition? Regards Bibo Mao 在 2023/8/8 18:03, Jiajie Chen 写道: > > On 2023

Re: [PATCH] target/loongarch: Split fcc register to fcc0-7 in gdbstub

2023-08-08 Thread Jiajie Chen
On 2023/8/8 17:55, Jiajie Chen wrote: On 2023/8/8 14:10, bibo mao wrote: I am not familiar with gdb, is there  abi breakage? I do not know how gdb client works with gdb server with different versions. There seemed no versioning in the process, but rather in-code xml validation. In gdb, the

Re: [PATCH] target/loongarch: Split fcc register to fcc0-7 in gdbstub

2023-08-08 Thread Jiajie Chen
On 2023/8/8 14:10, bibo mao wrote: I am not familiar with gdb, is there abi breakage? I do not know how gdb client works with gdb server with different versions. Not abi breakage, but gdb will complain: warning: while parsing target description (at line 1): Target description specified unk

Re: [PATCH] target/loongarch: Split fcc register to fcc0-7 in gdbstub

2023-08-07 Thread bibo mao
add loongarch gdb maintainer. 在 2023/8/8 14:10, bibo mao 写道: > > I am not familiar with gdb, is there abi breakage? > I do not know how gdb client works with gdb server with different versions. > > Regards > Bibo Mao > > > 在 2023/8/8 13:42, Jiajie Chen 写道: >> Since GDB 13.1(GDB commit ea33521

Re: [PATCH] target/loongarch: Split fcc register to fcc0-7 in gdbstub

2023-08-07 Thread bibo mao
I am not familiar with gdb, is there abi breakage? I do not know how gdb client works with gdb server with different versions. Regards Bibo Mao 在 2023/8/8 13:42, Jiajie Chen 写道: > Since GDB 13.1(GDB commit ea3352172), GDB LoongArch changed to use > fcc0-7 instead of fcc register. This commit

[PATCH] target/loongarch: Split fcc register to fcc0-7 in gdbstub

2023-08-07 Thread Jiajie Chen
Since GDB 13.1(GDB commit ea3352172), GDB LoongArch changed to use fcc0-7 instead of fcc register. This commit partially reverts commit 2f149c759 (`target/loongarch: Update gdb_set_fpu() and gdb_get_fpu()`) to match the behavior of GDB. Note that it is a breaking change for GDB 13.0 or earlier, bu