Re: [PATCH] target/i386: fix INSERTQ implementation

2022-09-19 Thread Richard Henderson
On 9/18/22 09:56, Paolo Bonzini wrote: +else { +if (mod != 3) { +gen_lea_modrm(env, s, modrm); +op2_offset = offsetof(CPUX86State, xmm_t0); +gen_ldq_env_A0(s, offsetof(CPUX86State, xmm_t0.

[PATCH] target/i386: fix INSERTQ implementation

2022-09-18 Thread Paolo Bonzini
INSERTQ is defined to not modify any bits in the lower 64 bits of the destination, other than the ones being replaced with bits from the source operand. QEMU instead is using unshifted bits from the source for those bits. Signed-off-by: Paolo Bonzini --- target/i386/ops_sse.h| 10 +-