Re: [PATCH] target/i386/cpu: add return value verification and ignore Error objects

2020-10-10 Thread Li Qiang
Pan Nengyuan 于2020年9月4日周五 下午3:19写道： > > 'err' is unnecessary in x86_cpu_class_check_missing_features(), we can change > x86_cpu_expand_features() > to return true on success, false on failure, then pass NULL here to remove it. > > Signed-off-by: Pan Nengyuan > Suggested-by: Markus Armbruster R

Re: [PATCH] target/i386/cpu: add return value verification and ignore Error objects

2020-10-10 Thread Pan Nengyuan
ping! Maybe missed to queue? On 2020/9/4 21:20, Philippe Mathieu-Daudé wrote: > On 9/4/20 3:45 PM, Pan Nengyuan wrote: >> 'err' is unnecessary in x86_cpu_class_check_missing_features(), we can >> change x86_cpu_expand_features() >> to return true on success, false on failure, then pass NULL here

Re: [PATCH] target/i386/cpu: add return value verification and ignore Error objects

2020-09-04 Thread Philippe Mathieu-Daudé
On 9/4/20 3:45 PM, Pan Nengyuan wrote: > 'err' is unnecessary in x86_cpu_class_check_missing_features(), we can change > x86_cpu_expand_features() > to return true on success, false on failure, then pass NULL here to remove it. > > Signed-off-by: Pan Nengyuan > Suggested-by: Markus Armbruster

[PATCH] target/i386/cpu: add return value verification and ignore Error objects

2020-09-04 Thread Pan Nengyuan
'err' is unnecessary in x86_cpu_class_check_missing_features(), we can change x86_cpu_expand_features() to return true on success, false on failure, then pass NULL here to remove it. Signed-off-by: Pan Nengyuan Suggested-by: Markus Armbruster --- target/i386/cpu.c | 15 +++ 1 file