On 1/13/2020 9:41 PM, Richard Henderson wrote:
> On 1/10/20 8:02 AM, Jeff Kubascik wrote:
>> -env->pc -= insn_len;
>> +if (env->aarch64)
>> +env->pc -= insn_len;
>> +else
>> +env->regs[15] -= insn_len;
>
> QEMU requires all braces. See CODING_STYLE.
On 1/10/20 8:02 AM, Jeff Kubascik wrote:
> -env->pc -= insn_len;
> +if (env->aarch64)
> +env->pc -= insn_len;
> +else
> +env->regs[15] -= insn_len;
QEMU requires all braces. See CODING_STYLE.
Otherwise,
Reviewed-by: Richard Henderson
r~
Patchew URL:
https://patchew.org/QEMU/20200110180211.29025-1-jeff.kubas...@dornerworks.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] target/arm: adjust program counter for wfi exception in AArch32
Type: series
Message
The wfi instruction can be configured to be trapped by a higher exception
level, such as the EL2 hypervisor. When the instruction is trapped, the
program counter should contain the address of the wfi instruction that
caused the exception. The program counter is adjusted for this in the wfi op
helpe
