Re: [PATCH] target/arm: Fix MTE0_ACTIVE

2021-01-07 Thread Peter Maydell
On Thu, 7 Jan 2021 at 19:10, Richard Henderson wrote: > > On 1/7/21 7:54 AM, Peter Maydell wrote: > >> -&& (sctlr & SCTLR_TCF0) > >> +&& (sctlr & SCTLR_TCF) > >> && allocation_tag_access_enabled(env, 0, sctlr)) { > >> flags = FIELD_DP32(flags, TBFL

Re: [PATCH] target/arm: Fix MTE0_ACTIVE

2021-01-07 Thread Richard Henderson
On 1/7/21 7:54 AM, Peter Maydell wrote: >> -&& (sctlr & SCTLR_TCF0) >> +&& (sctlr & SCTLR_TCF) >> && allocation_tag_access_enabled(env, 0, sctlr)) { >> flags = FIELD_DP32(flags, TBFLAG_A64, MTE0_ACTIVE, 1); >> } > > > I don't understand t

Re: [PATCH] target/arm: Fix MTE0_ACTIVE

2021-01-07 Thread Peter Maydell
On Mon, 21 Dec 2020 at 20:44, Richard Henderson wrote: > > In 50244cc76abc we updated mte_check_fail to match the ARM > pseudocode, using the correct EL to select the TCF field. > But we failed to update MTE0_ACTIVE the same way, which led > to g_assert_not_reached(). > > Cc: qemu-sta...@nongnu.or

[PATCH] target/arm: Fix MTE0_ACTIVE

2020-12-21 Thread Richard Henderson
In 50244cc76abc we updated mte_check_fail to match the ARM pseudocode, using the correct EL to select the TCF field. But we failed to update MTE0_ACTIVE the same way, which led to g_assert_not_reached(). Cc: qemu-sta...@nongnu.org Buglink: https://bugs.launchpad.net/bugs/1907137 Signed-off-by: Ric