Re: [PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

2024-03-12 Thread Philippe Mathieu-Daudé
On 12/3/24 20:24, Peter Xu wrote: On Tue, Mar 12, 2024 at 06:38:13PM +0100, Thomas Huth wrote: Hi Peter, Paolo, David, this patch fixes a problem with the kvm-unit-tests ... could we get it included in QEMU 9.0 ? Yes I think so. Apologies for a long delay, I queued it for the next rc pull

Re: [PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

2024-03-12 Thread Peter Xu
On Tue, Mar 12, 2024 at 06:38:13PM +0100, Thomas Huth wrote: > > Hi Peter, Paolo, David, > > this patch fixes a problem with the kvm-unit-tests ... could we get it > included in QEMU 9.0 ? Yes I think so. Apologies for a long delay, I queued it for the next rc pull. Thanks, -- Peter Xu

Re: [PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

2024-03-12 Thread Thomas Huth
Hi Peter, Paolo, David, this patch fixes a problem with the kvm-unit-tests ... could we get it included in QEMU 9.0 ? Thanks, Thomas On 19/02/2024 07.17, Nicholas Piggin wrote: The fastpath in cpu_physical_memory_sync_dirty_bitmap() to test large aligned ranges forgot to bring the TCG

Re: [PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

2024-02-22 Thread Nicholas Piggin
On Fri Feb 23, 2024 at 6:59 AM AEST, Thomas Huth wrote: > On 20/02/2024 02.13, Nicholas Piggin wrote: > > On Tue Feb 20, 2024 at 12:10 AM AEST, Thomas Huth wrote: > >> On 19/02/2024 07.17, Nicholas Piggin wrote: > >>> The fastpath in cpu_physical_memory_sync_dirty_bitmap() to test large > >>> align

Re: [PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

2024-02-22 Thread Thomas Huth
On 20/02/2024 02.13, Nicholas Piggin wrote: On Tue Feb 20, 2024 at 12:10 AM AEST, Thomas Huth wrote: On 19/02/2024 07.17, Nicholas Piggin wrote: The fastpath in cpu_physical_memory_sync_dirty_bitmap() to test large aligned ranges forgot to bring the TCG TLB up to date after clearing some of the

Re: [PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

2024-02-19 Thread Nicholas Piggin
On Tue Feb 20, 2024 at 12:10 AM AEST, Thomas Huth wrote: > On 19/02/2024 07.17, Nicholas Piggin wrote: > > The fastpath in cpu_physical_memory_sync_dirty_bitmap() to test large > > aligned ranges forgot to bring the TCG TLB up to date after clearing > > some of the dirty memory bitmap bits. This ca

Re: [PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

2024-02-19 Thread Nicholas Piggin
On Tue Feb 20, 2024 at 12:10 AM AEST, Thomas Huth wrote: > On 19/02/2024 07.17, Nicholas Piggin wrote: > > The fastpath in cpu_physical_memory_sync_dirty_bitmap() to test large > > aligned ranges forgot to bring the TCG TLB up to date after clearing > > some of the dirty memory bitmap bits. This ca

Re: [PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

2024-02-19 Thread Thomas Huth
On 19/02/2024 07.17, Nicholas Piggin wrote: The fastpath in cpu_physical_memory_sync_dirty_bitmap() to test large aligned ranges forgot to bring the TCG TLB up to date after clearing some of the dirty memory bitmap bits. This can result in stores though the TCG TLB not setting the dirty memory bi

[PATCH] system/physmem: Fix migration dirty bitmap coherency with TCG memory access

2024-02-18 Thread Nicholas Piggin
The fastpath in cpu_physical_memory_sync_dirty_bitmap() to test large aligned ranges forgot to bring the TCG TLB up to date after clearing some of the dirty memory bitmap bits. This can result in stores though the TCG TLB not setting the dirty memory bitmap and ultimately causes memory corruption /