Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-22 Thread David Gibson
On Wed, Jan 22, 2020 at 11:06:18AM +0100, Greg Kurz wrote: > On Wed, 22 Jan 2020 17:50:28 +1100 > David Gibson wrote: > > > On Tue, Jan 21, 2020 at 10:32:55AM +0100, Greg Kurz wrote: > > > On Tue, 21 Jan 2020 14:43:32 +1100 > > > David Gibson wrote: > > > > > > > On Mon, Jan 20, 2020 at 09:04:3

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-22 Thread Cédric Le Goater
On 1/22/20 1:47 PM, Greg Kurz wrote: > On Wed, 15 Jan 2020 19:10:47 +0100 > Cédric Le Goater wrote: > >> On 1/15/20 6:48 PM, Greg Kurz wrote: >>> Migration can potentially race with CAS reboot. If the migration thread >>> completes migration after CAS has set spapr->cas_reboot but before the >>>

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-22 Thread Greg Kurz
On Wed, 15 Jan 2020 19:10:47 +0100 Cédric Le Goater wrote: > On 1/15/20 6:48 PM, Greg Kurz wrote: > > Migration can potentially race with CAS reboot. If the migration thread > > completes migration after CAS has set spapr->cas_reboot but before the > > mainloop could pick up the reset request and

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-22 Thread Greg Kurz
On Wed, 22 Jan 2020 17:50:28 +1100 David Gibson wrote: > On Tue, Jan 21, 2020 at 10:32:55AM +0100, Greg Kurz wrote: > > On Tue, 21 Jan 2020 14:43:32 +1100 > > David Gibson wrote: > > > > > On Mon, Jan 20, 2020 at 09:04:38AM +0100, Greg Kurz wrote: > > > > On Fri, 17 Jan 2020 16:44:27 +0100 > >

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-21 Thread David Gibson
On Tue, Jan 21, 2020 at 10:32:55AM +0100, Greg Kurz wrote: > On Tue, 21 Jan 2020 14:43:32 +1100 > David Gibson wrote: > > > On Mon, Jan 20, 2020 at 09:04:38AM +0100, Greg Kurz wrote: > > > On Fri, 17 Jan 2020 16:44:27 +0100 > > > Greg Kurz wrote: > > > > > > > On Fri, 17 Jan 2020 19:16:08 +1000

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-21 Thread Greg Kurz
On Tue, 21 Jan 2020 14:43:32 +1100 David Gibson wrote: > On Mon, Jan 20, 2020 at 09:04:38AM +0100, Greg Kurz wrote: > > On Fri, 17 Jan 2020 16:44:27 +0100 > > Greg Kurz wrote: > > > > > On Fri, 17 Jan 2020 19:16:08 +1000 > > > David Gibson wrote: > > > > > > > On Thu, Jan 16, 2020 at 07:29:02

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-20 Thread Greg Kurz
On Tue, 21 Jan 2020 14:41:26 +1100 David Gibson wrote: > On Wed, Jan 15, 2020 at 07:10:47PM +0100, Cédric Le Goater wrote: > > On 1/15/20 6:48 PM, Greg Kurz wrote: > > > Migration can potentially race with CAS reboot. If the migration thread > > > completes migration after CAS has set spapr->cas_

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-20 Thread Cédric Le Goater
On 1/21/20 4:41 AM, David Gibson wrote: > On Wed, Jan 15, 2020 at 07:10:47PM +0100, Cédric Le Goater wrote: >> On 1/15/20 6:48 PM, Greg Kurz wrote: >>> Migration can potentially race with CAS reboot. If the migration thread >>> completes migration after CAS has set spapr->cas_reboot but before the

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-20 Thread David Gibson
On Wed, Jan 15, 2020 at 07:10:47PM +0100, Cédric Le Goater wrote: > On 1/15/20 6:48 PM, Greg Kurz wrote: > > Migration can potentially race with CAS reboot. If the migration thread > > completes migration after CAS has set spapr->cas_reboot but before the > > mainloop could pick up the reset reques

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-20 Thread David Gibson
On Mon, Jan 20, 2020 at 09:04:38AM +0100, Greg Kurz wrote: > On Fri, 17 Jan 2020 16:44:27 +0100 > Greg Kurz wrote: > > > On Fri, 17 Jan 2020 19:16:08 +1000 > > David Gibson wrote: > > > > > On Thu, Jan 16, 2020 at 07:29:02PM +0100, Greg Kurz wrote: > > > > On Thu, 16 Jan 2020 13:14:35 +0100 > >

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-20 Thread Greg Kurz
On Fri, 17 Jan 2020 16:44:27 +0100 Greg Kurz wrote: > On Fri, 17 Jan 2020 19:16:08 +1000 > David Gibson wrote: > > > On Thu, Jan 16, 2020 at 07:29:02PM +0100, Greg Kurz wrote: > > > On Thu, 16 Jan 2020 13:14:35 +0100 > > > Greg Kurz wrote: > > > > > > > On Thu, 16 Jan 2020 11:37:24 +0100 > >

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread Greg Kurz
On Fri, 17 Jan 2020 13:10:35 +0100 Laurent Vivier wrote: > On 17/01/2020 12:49, Greg Kurz wrote: > > On Wed, 15 Jan 2020 19:26:18 +0100 > > Laurent Vivier wrote: > > > >> On 15/01/2020 19:10, Laurent Vivier wrote: > >>> Hi, > >>> > >>> On 15/01/2020 18:48, Greg Kurz wrote: > Migration can

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread Greg Kurz
On Fri, 17 Jan 2020 19:16:08 +1000 David Gibson wrote: > On Thu, Jan 16, 2020 at 07:29:02PM +0100, Greg Kurz wrote: > > On Thu, 16 Jan 2020 13:14:35 +0100 > > Greg Kurz wrote: > > > > > On Thu, 16 Jan 2020 11:37:24 +0100 > > > Laurent Vivier wrote: > > > > > > > On 16/01/2020 09:48, Greg Kurz

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread David Gibson
On Thu, Jan 16, 2020 at 07:29:02PM +0100, Greg Kurz wrote: > On Thu, 16 Jan 2020 13:14:35 +0100 > Greg Kurz wrote: > > > On Thu, 16 Jan 2020 11:37:24 +0100 > > Laurent Vivier wrote: > > > > > On 16/01/2020 09:48, Greg Kurz wrote: > > > > On Wed, 15 Jan 2020 19:10:37 +0100 > > > > Laurent Vivier

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread Laurent Vivier
On 17/01/2020 12:49, Greg Kurz wrote: > On Wed, 15 Jan 2020 19:26:18 +0100 > Laurent Vivier wrote: > >> On 15/01/2020 19:10, Laurent Vivier wrote: >>> Hi, >>> >>> On 15/01/2020 18:48, Greg Kurz wrote: Migration can potentially race with CAS reboot. If the migration thread completes migr

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-17 Thread Greg Kurz
On Wed, 15 Jan 2020 19:26:18 +0100 Laurent Vivier wrote: > On 15/01/2020 19:10, Laurent Vivier wrote: > > Hi, > > > > On 15/01/2020 18:48, Greg Kurz wrote: > >> Migration can potentially race with CAS reboot. If the migration thread > >> completes migration after CAS has set spapr->cas_reboot bu

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-16 Thread Greg Kurz
On Thu, 16 Jan 2020 13:14:35 +0100 Greg Kurz wrote: > On Thu, 16 Jan 2020 11:37:24 +0100 > Laurent Vivier wrote: > > > On 16/01/2020 09:48, Greg Kurz wrote: > > > On Wed, 15 Jan 2020 19:10:37 +0100 > > > Laurent Vivier wrote: > > > > > >> Hi, > > >> > > >> On 15/01/2020 18:48, Greg Kurz wrote

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-16 Thread Greg Kurz
On Thu, 16 Jan 2020 11:37:24 +0100 Laurent Vivier wrote: > On 16/01/2020 09:48, Greg Kurz wrote: > > On Wed, 15 Jan 2020 19:10:37 +0100 > > Laurent Vivier wrote: > > > >> Hi, > >> > >> On 15/01/2020 18:48, Greg Kurz wrote: > >>> Migration can potentially race with CAS reboot. If the migration t

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-16 Thread Laurent Vivier
On 16/01/2020 09:48, Greg Kurz wrote: > On Wed, 15 Jan 2020 19:10:37 +0100 > Laurent Vivier wrote: > >> Hi, >> >> On 15/01/2020 18:48, Greg Kurz wrote: >>> Migration can potentially race with CAS reboot. If the migration thread >>> completes migration after CAS has set spapr->cas_reboot but befor

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-16 Thread Greg Kurz
On Wed, 15 Jan 2020 19:10:37 +0100 Laurent Vivier wrote: > Hi, > > On 15/01/2020 18:48, Greg Kurz wrote: > > Migration can potentially race with CAS reboot. If the migration thread > > completes migration after CAS has set spapr->cas_reboot but before the > > mainloop could pick up the reset req

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-15 Thread Laurent Vivier
On 15/01/2020 19:10, Laurent Vivier wrote: > Hi, > > On 15/01/2020 18:48, Greg Kurz wrote: >> Migration can potentially race with CAS reboot. If the migration thread >> completes migration after CAS has set spapr->cas_reboot but before the >> mainloop could pick up the reset request and reset the

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-15 Thread Laurent Vivier
Hi, On 15/01/2020 18:48, Greg Kurz wrote: > Migration can potentially race with CAS reboot. If the migration thread > completes migration after CAS has set spapr->cas_reboot but before the > mainloop could pick up the reset request and reset the machine, the > guest is migrated unrebooted and the

Re: [PATCH] spapr: Migrate CAS reboot flag

2020-01-15 Thread Cédric Le Goater
On 1/15/20 6:48 PM, Greg Kurz wrote: > Migration can potentially race with CAS reboot. If the migration thread > completes migration after CAS has set spapr->cas_reboot but before the > mainloop could pick up the reset request and reset the machine, the > guest is migrated unrebooted and the destin

[PATCH] spapr: Migrate CAS reboot flag

2020-01-15 Thread Greg Kurz
Migration can potentially race with CAS reboot. If the migration thread completes migration after CAS has set spapr->cas_reboot but before the mainloop could pick up the reset request and reset the machine, the guest is migrated unrebooted and the destination doesn't reboot it either because it isn