Re: [PATCH] spapr/xive: skip partially initialized vCPUs in presenter

2019-10-03 Thread Cédric Le Goater
On 03/10/2019 00:37, David Gibson wrote: > On Wed, Oct 02, 2019 at 04:47:56PM +0200, Cédric Le Goater wrote: >> On 02/10/2019 16:21, Greg Kurz wrote: >>> On Wed, 2 Oct 2019 11:02:45 +1000 >>> David Gibson wrote: >>> On Tue, Oct 01, 2019 at 06:56:28PM +0200, Greg Kurz wrote: > On Tue, 1 Oc

Re: [PATCH] spapr/xive: skip partially initialized vCPUs in presenter

2019-10-02 Thread David Gibson
On Wed, Oct 02, 2019 at 04:47:56PM +0200, Cédric Le Goater wrote: > On 02/10/2019 16:21, Greg Kurz wrote: > > On Wed, 2 Oct 2019 11:02:45 +1000 > > David Gibson wrote: > > > >> On Tue, Oct 01, 2019 at 06:56:28PM +0200, Greg Kurz wrote: > >>> On Tue, 1 Oct 2019 13:56:10 +0200 > >>> Cédric Le Goate

Re: [PATCH] spapr/xive: skip partially initialized vCPUs in presenter

2019-10-02 Thread Cédric Le Goater
On 02/10/2019 16:21, Greg Kurz wrote: > On Wed, 2 Oct 2019 11:02:45 +1000 > David Gibson wrote: > >> On Tue, Oct 01, 2019 at 06:56:28PM +0200, Greg Kurz wrote: >>> On Tue, 1 Oct 2019 13:56:10 +0200 >>> Cédric Le Goater wrote: >>> On 01/10/2019 13:06, Greg Kurz wrote: > On Tue, 1 Oct 20

Re: [PATCH] spapr/xive: skip partially initialized vCPUs in presenter

2019-10-02 Thread Greg Kurz
On Wed, 2 Oct 2019 11:02:45 +1000 David Gibson wrote: > On Tue, Oct 01, 2019 at 06:56:28PM +0200, Greg Kurz wrote: > > On Tue, 1 Oct 2019 13:56:10 +0200 > > Cédric Le Goater wrote: > > > > > On 01/10/2019 13:06, Greg Kurz wrote: > > > > On Tue, 1 Oct 2019 10:57:22 +0200 > > > > Cédric Le Goate

Re: [PATCH] spapr/xive: skip partially initialized vCPUs in presenter

2019-10-01 Thread David Gibson
On Tue, Oct 01, 2019 at 06:56:28PM +0200, Greg Kurz wrote: > On Tue, 1 Oct 2019 13:56:10 +0200 > Cédric Le Goater wrote: > > > On 01/10/2019 13:06, Greg Kurz wrote: > > > On Tue, 1 Oct 2019 10:57:22 +0200 > > > Cédric Le Goater wrote: > > > > > >> When vCPUs are hotplugged, they are added to t

Re: [PATCH] spapr/xive: skip partially initialized vCPUs in presenter

2019-10-01 Thread Greg Kurz
On Tue, 1 Oct 2019 13:56:10 +0200 Cédric Le Goater wrote: > On 01/10/2019 13:06, Greg Kurz wrote: > > On Tue, 1 Oct 2019 10:57:22 +0200 > > Cédric Le Goater wrote: > > > >> When vCPUs are hotplugged, they are added to the QEMU CPU list before > >> being fully realized. This can crash the XIVE

Re: [PATCH] spapr/xive: skip partially initialized vCPUs in presenter

2019-10-01 Thread Cédric Le Goater
On 01/10/2019 13:06, Greg Kurz wrote: > On Tue, 1 Oct 2019 10:57:22 +0200 > Cédric Le Goater wrote: > >> When vCPUs are hotplugged, they are added to the QEMU CPU list before >> being fully realized. This can crash the XIVE presenter because the >> 'tctx' pointer is not necessarily initialized w

Re: [PATCH] spapr/xive: skip partially initialized vCPUs in presenter

2019-10-01 Thread Greg Kurz
On Tue, 1 Oct 2019 10:57:22 +0200 Cédric Le Goater wrote: > When vCPUs are hotplugged, they are added to the QEMU CPU list before > being fully realized. This can crash the XIVE presenter because the > 'tctx' pointer is not necessarily initialized when looking for a > matching target. > Ouch..

[PATCH] spapr/xive: skip partially initialized vCPUs in presenter

2019-10-01 Thread Cédric Le Goater
When vCPUs are hotplugged, they are added to the QEMU CPU list before being fully realized. This can crash the XIVE presenter because the 'tctx' pointer is not necessarily initialized when looking for a matching target. These vCPUs are not valid targets for the presenter. Skip them. Signed-off-by