Re: [PATCH] rust: tests: do not import bindings::*

2025-02-14 Thread Paolo Bonzini
First of all, thanks for taking a look!! > > prelude::*, > > Should this be expanded too if we want to discourage wildcard imports ? The prelude is a bit special; it provides a subset of items that most users will want to include into the namespace. You're right that it goes against the rule

Re: [PATCH] rust: tests: do not import bindings::*

2025-02-14 Thread Daniel P . Berrangé
On Fri, Feb 14, 2025 at 02:58:22PM +0100, Paolo Bonzini wrote: > Similar to the devices, spell the exact set of C functions that are > called directly. > > Signed-off-by: Paolo Bonzini > --- > rust/qemu-api/tests/tests.rs | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

[PATCH] rust: tests: do not import bindings::*

2025-02-14 Thread Paolo Bonzini
Similar to the devices, spell the exact set of C functions that are called directly. Signed-off-by: Paolo Bonzini --- rust/qemu-api/tests/tests.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/rust/qemu-api/tests/tests.rs b/rust/qemu-api/tests/tests.rs index 92dbfb8a0c8..