Re: [PATCH] runstate: cleanup reboot and panic actions

2021-01-20 Thread Alejandro Jimenez
On 1/20/2021 9:37 AM, Paolo Bonzini wrote: The possible choices for panic, reset and watchdog actions are inconsistent. "-action panic=poweroff" should be renamed to "-action panic=shutdown" on the command line. This is because "-action panic=poweroff" and "-action watchdog=poweroff" have sl

Re: [PATCH] runstate: cleanup reboot and panic actions

2021-01-20 Thread Eric Blake
On 1/20/21 8:37 AM, Paolo Bonzini wrote: > The possible choices for panic, reset and watchdog actions are inconsistent. > > "-action panic=poweroff" should be renamed to "-action panic=shutdown" > on the command line. This is because "-action panic=poweroff" and > "-action watchdog=poweroff" have

Re: [PATCH] runstate: cleanup reboot and panic actions

2021-01-20 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210120143706.345821-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210120143706.345821-1-pbonz...@redhat.com Subject: [PATCH] runstate: cleanup reboot

[PATCH] runstate: cleanup reboot and panic actions

2021-01-20 Thread Paolo Bonzini
The possible choices for panic, reset and watchdog actions are inconsistent. "-action panic=poweroff" should be renamed to "-action panic=shutdown" on the command line. This is because "-action panic=poweroff" and "-action watchdog=poweroff" have slightly different semantics, the first does an un