Re: [PATCH] remote/memory: Replace share parameter with ram_flags

2021-07-08 Thread Peter Xu
On Thu, Jul 08, 2021 at 03:12:16PM +0800, Yang Zhong wrote: > The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd() > in the hw/remote/memory.c. > > Signed-off-by: Yang Zhong Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH] remote/memory: Replace share parameter with ram_flags

2021-07-08 Thread Yang Zhong
On Thu, Jul 08, 2021 at 09:26:17AM +0200, David Hildenbrand wrote: > On 08.07.21 09:12, Yang Zhong wrote: > >The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd() > >in the hw/remote/memory.c. > > Yes, seems like that call was added just after I crafted my patches: > > Fix

Re: [PATCH] remote/memory: Replace share parameter with ram_flags

2021-07-08 Thread David Hildenbrand
On 08.07.21 09:12, Yang Zhong wrote: The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd() in the hw/remote/memory.c. Yes, seems like that call was added just after I crafted my patches: Fixes: d5015b801340 ("softmmu/memory: Pass ram_flags to qemu_ram_alloc_from_fd()")

[PATCH] remote/memory: Replace share parameter with ram_flags

2021-07-08 Thread Yang Zhong
The commit(d5015b80) missed the ram_flags to memory_region_init_ram_from_fd() in the hw/remote/memory.c. Signed-off-by: Yang Zhong --- hw/remote/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/remote/memory.c b/hw/remote/memory.c index 472ed2a272..6e21ab1a45 10064