On Thu, Jan 23, 2020 at 08:36:26PM +0100, salva...@qindel.com wrote:
> From: Salvador Fandino
>
> NULL is a valid log filename used to indicate we want to use stderr
> but qemu_set_log_filename (which is called by bsd-user/main.c) was not
> handling it correctly.
>
> That also made redundant a c
On Thu, Jan 23, 2020 at 08:36:26PM +0100, salva...@qindel.com wrote:
> From: Salvador Fandino
>
> NULL is a valid log filename used to indicate we want to use stderr
> but qemu_set_log_filename (which is called by bsd-user/main.c) was not
> handling it correctly.
>
> That also made redundant a c
From: Salvador Fandino
NULL is a valid log filename used to indicate we want to use stderr
but qemu_set_log_filename (which is called by bsd-user/main.c) was not
handling it correctly.
That also made redundant a couple of NULL checks in calling code which
have been removed.
Signed-off-by: Salva
On Wed, Jan 22, 2020 at 10:08:12PM +0100, salva...@qindel.com wrote:
Existing callers like vl.c:main() do:
if (log_file) {
qemu_set_log_filename(log_file, &error_fatal);
}
Please fix up existing callers. They won't need to check for NULL
anymore before calling qemu_set_log_filenam
From: Salvador Fandino
NULL is a valid log filename used to indicate we want to use stderr
but qemu_set_log_filename (which is called by bsd-user/main.c) was not
handling it correctly.
Signed-off-by: Salvador Fandino
---
util/log.c | 27 +++
1 file changed, 15 insertion
From: Salvador Fandino
NULL is a valid log filename used to indicate we want to use stderr
but qemu_set_log_filename (which is called by bsd-user/main.c) was not
handling it correctly.
Signed-off-by: Salvador Fandino
---
util/log.c | 27 +++
1 file changed, 15 insertion
