Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG

2020-02-06 Thread Laurent Vivier
Le 04/02/2020 à 17:56, John Snow a écrit : > This is the only instance of a non-zero constant not using a symbolic > constant. > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 224a8e8712..ff3e806977 100644 >

Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG

2020-02-04 Thread John Snow
On 2/4/20 11:56 AM, John Snow wrote: > This is the only instance of a non-zero constant not using a symbolic > constant. Signed-off-by: John Snow > --- > qemu-options.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 224a8e

Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG

2020-02-04 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200204165638.25051-1-js...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] qemu-options: replace constant 1 with HAS_ARG Message-id: 20200204165638.25051-1-js...@redhat.com

Re: [PATCH] qemu-options: replace constant 1 with HAS_ARG

2020-02-04 Thread Eric Blake
On 2/4/20 10:56 AM, John Snow wrote: This is the only instance of a non-zero constant not using a symbolic constant. --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake diff --git a/qemu-options.hx b/qemu-options.hx index 224a8e8712..ff3e8069

[PATCH] qemu-options: replace constant 1 with HAS_ARG

2020-02-04 Thread John Snow
This is the only instance of a non-zero constant not using a symbolic constant. --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 224a8e8712..ff3e806977 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1955,7 +1955