Re: [PATCH] qcow2: Use offset_into_cluster()

2019-12-13 Thread Kevin Wolf
Am 12.12.2019 um 11:01 hat Alberto Garcia geschrieben: > There's a couple of places left in the qcow2 code that still do the > calculation manually, so let's replace them. > > Signed-off-by: Alberto Garcia Thanks, applied to the block branch. Kevin

Re: [PATCH] qcow2: Use offset_into_cluster()

2019-12-12 Thread Eric Blake
On 12/12/19 4:01 AM, Alberto Garcia wrote: There's a couple of places left in the qcow2 code that still do the calculation manually, so let's replace them. Signed-off-by: Alberto Garcia --- block/qcow2.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake

[PATCH] qcow2: Use offset_into_cluster()

2019-12-12 Thread Alberto Garcia
There's a couple of places left in the qcow2 code that still do the calculation manually, so let's replace them. Signed-off-by: Alberto Garcia --- block/qcow2.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 7c18721741..3866b47946

Re: [Qemu-devel] [PATCH] qcow2: Use offset_into_cluster() and offset_to_l2_index()

2017-06-20 Thread Kevin Wolf
Am 20.06.2017 um 15:01 hat Alberto Garcia geschrieben: > We already have functions for doing these calculations, so let's use > them instead of doing everything by hand. This makes the code a bit > more readable. > > Signed-off-by: Alberto Garcia Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH] qcow2: Use offset_into_cluster() and offset_to_l2_index()

2017-06-20 Thread Alberto Garcia
We already have functions for doing these calculations, so let's use them instead of doing everything by hand. This makes the code a bit more readable. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 4 ++-- block/qcow2.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)