Re: [PATCH] qapi: Make some ObjectTypes depend on the build settings

2021-10-09 Thread Markus Armbruster
Paolo Bonzini writes: > On 08/10/21 14:01, Markus Armbruster wrote: >> Paolo, do you have something for QOM queued up already? If not, I'm >> happy to take this through my tree. >> > > I don't but I have enough stuff that I'll be sending a pull request > shortly. So, queued, and while at it I

Re: [PATCH] qapi: Make some ObjectTypes depend on the build settings

2021-10-08 Thread Paolo Bonzini
On 08/10/21 14:01, Markus Armbruster wrote: Paolo, do you have something for QOM queued up already? If not, I'm happy to take this through my tree. I don't but I have enough stuff that I'll be sending a pull request shortly. So, queued, and while at it I also made memory-backend-epc depend

Re: [PATCH] qapi: Make some ObjectTypes depend on the build settings

2021-10-08 Thread Markus Armbruster
Paolo, do you have something for QOM queued up already? If not, I'm happy to take this through my tree.

Re: [PATCH] qapi: Make some ObjectTypes depend on the build settings

2021-10-05 Thread Markus Armbruster
Thomas Huth writes: > Some of the ObjectType entries already depend on CONFIG_* switches. > Some others also only make sense with certain configurations, but > are currently always listed in the ObjectType enum. Let's make them > depend on the correpsonding CONFIG_* switches, too, so that upper >

Re: [PATCH] qapi: Make some ObjectTypes depend on the build settings

2021-10-04 Thread Thomas Huth
On 29/09/2021 13.41, Markus Armbruster wrote: [...] In my opinion, use of CONFIG_FOO in QAPI schemata is no worse than using them in C type definitions. In both cases, we have a choice: compile out stuff this build doesn't need with compile-time conditionals, or leave it in unused. In C, we som

Re: [PATCH] qapi: Make some ObjectTypes depend on the build settings

2021-09-29 Thread Markus Armbruster
Thomas Huth writes: > On 28/09/2021 19.39, Philippe Mathieu-Daudé wrote: >> I quickly opened qapi/qom.json and spotted another one: >> --- a/qapi/qom.json >> +++ b/qapi/qom.json >> @@ -870,3 +870,4 @@ >> 'tls-cipher-suites': 'TlsCredsProperties', >> - 'x-remote-object':

Re: [PATCH] qapi: Make some ObjectTypes depend on the build settings

2021-09-28 Thread Thomas Huth
On 28/09/2021 19.39, Philippe Mathieu-Daudé wrote: On 9/28/21 18:02, Thomas Huth wrote: Some of the ObjectType entries already depend on CONFIG_* switches. Some others also only make sense with certain configurations, but are currently always listed in the ObjectType enum. Let's make them depend

Re: [PATCH] qapi: Make some ObjectTypes depend on the build settings

2021-09-28 Thread Philippe Mathieu-Daudé
On 9/28/21 18:02, Thomas Huth wrote: > Some of the ObjectType entries already depend on CONFIG_* switches. > Some others also only make sense with certain configurations, but > are currently always listed in the ObjectType enum. Let's make them > depend on the correpsonding CONFIG_* switches, too,

[PATCH] qapi: Make some ObjectTypes depend on the build settings

2021-09-28 Thread Thomas Huth
Some of the ObjectType entries already depend on CONFIG_* switches. Some others also only make sense with certain configurations, but are currently always listed in the ObjectType enum. Let's make them depend on the correpsonding CONFIG_* switches, too, so that upper layers (like libvirt) have a be