Re: [PATCH] qapi: Fix crash on redefinition with a different condition

2021-08-06 Thread Eric Blake
On Fri, Aug 06, 2021 at 02:05:10PM +0200, Markus Armbruster wrote: > QAPISchema._make_implicit_object_type() asserts that when an implicit > object type is used multiple times, @ifcond is the same for all uses. > It will be for legitimate uses, i.e. simple union branch wrapper > types. A comment e

[PATCH] qapi: Fix crash on redefinition with a different condition

2021-08-06 Thread Markus Armbruster
QAPISchema._make_implicit_object_type() asserts that when an implicit object type is used multiple times, @ifcond is the same for all uses. It will be for legitimate uses, i.e. simple union branch wrapper types. A comment explains this. The assertion fails when a command or event is redefined wit