Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-02-07 Thread Eduardo Habkost
On Sat, Jan 18, 2020 at 07:54:18AM +0100, Markus Armbruster wrote: > John Snow writes: > > On 1/17/20 2:07 AM, Markus Armbruster wrote: > >> John Snow writes: [...] > >>> This problem has bitten me *many* times. I'm wondering if there's a > >>> prescription that isn't just "Wait until we can stip

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-20 Thread Peter Maydell
On Thu, 16 Jan 2020 at 20:27, Markus Armbruster wrote: > > Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" > modules" switched QAPISchema.visit() from > > for entity in self._entity_list: > > effectively to > > for mod in self._module_dict.values(): > for ent

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-20 Thread Alex Bennée
Markus Armbruster writes: > Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" > modules" switched QAPISchema.visit() from > > for entity in self._entity_list: > > effectively to > > for mod in self._module_dict.values(): > for entity in mod._entity_list: > >

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-19 Thread Philippe Mathieu-Daudé
On 1/18/20 9:33 AM, Philippe Mathieu-Daudé wrote: > On 1/17/20 11:49 AM, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> On 16/01/2020 21.25, Markus Armbruster wrote: Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" modules" switched QAPISchema.visit() from >

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-18 Thread Philippe Mathieu-Daudé
On 1/17/20 11:49 AM, Markus Armbruster wrote: Thomas Huth writes: On 16/01/2020 21.25, Markus Armbruster wrote: Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" modules" switched QAPISchema.visit() from for entity in self._entity_list: effectively to for mod

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-18 Thread Philippe Mathieu-Daudé
On 1/17/20 8:41 PM, John Snow wrote: On 1/17/20 2:07 AM, Markus Armbruster wrote: John Snow writes: On 1/16/20 3:25 PM, Markus Armbruster wrote: Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" modules" switched QAPISchema.visit() from for entity in self._entity_l

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-17 Thread Markus Armbruster
John Snow writes: > On 1/17/20 2:07 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 1/16/20 3:25 PM, Markus Armbruster wrote: Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" modules" switched QAPISchema.visit() from for entity in self._

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-17 Thread John Snow
On 1/17/20 2:07 AM, Markus Armbruster wrote: > John Snow writes: > >> On 1/16/20 3:25 PM, Markus Armbruster wrote: >>> Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" >>> modules" switched QAPISchema.visit() from >>> >>> for entity in self._entity_list: >>> >>> effec

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-17 Thread Markus Armbruster
Thomas Huth writes: > On 16/01/2020 21.25, Markus Armbruster wrote: >> Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" >> modules" switched QAPISchema.visit() from >> >> for entity in self._entity_list: >> >> effectively to >> >> for mod in self._module_dict.valu

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-17 Thread Thomas Huth
On 16/01/2020 21.25, Markus Armbruster wrote: > Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" > modules" switched QAPISchema.visit() from > > for entity in self._entity_list: > > effectively to > > for mod in self._module_dict.values(): > for entity in mo

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-16 Thread Markus Armbruster
John Snow writes: > On 1/16/20 3:25 PM, Markus Armbruster wrote: >> Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" >> modules" switched QAPISchema.visit() from >> >> for entity in self._entity_list: >> >> effectively to >> >> for mod in self._module_dict.values(

Re: [PATCH] qapi: Fix code generation with Python 3.5

2020-01-16 Thread John Snow
On 1/16/20 3:25 PM, Markus Armbruster wrote: > Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" > modules" switched QAPISchema.visit() from > > for entity in self._entity_list: > > effectively to > > for mod in self._module_dict.values(): > for entity in

[PATCH] qapi: Fix code generation with Python 3.5

2020-01-16 Thread Markus Armbruster
Recent commit 3e7fb5811b "qapi: Fix code generation for empty modules" modules" switched QAPISchema.visit() from for entity in self._entity_list: effectively to for mod in self._module_dict.values(): for entity in mod._entity_list: Visits in the same order as long as .values() i