Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-25 Thread Vladimir Sementsov-Ogievskiy
21.12.2019 1:04, Eric Blake wrote: > On 12/19/19 10:14 AM, Nir Soffer wrote: > > 1. Using disk name as a bitmap name is a bad behavior, as they are > completely > different concepts. Especially keeping in mind that user already knows > disk name anyway > and no reason to writ

Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-20 Thread Eric Blake
On 12/19/19 10:14 AM, Nir Soffer wrote: 1. Using disk name as a bitmap name is a bad behavior, as they are completely different concepts. Especially keeping in mind that user already knows disk name anyway and no reason to write this export name inside metadata context of this export. The dif

Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-20 Thread Eric Blake
On 12/19/19 9:08 AM, Nir Soffer wrote: Let's just fix qapi spec now. But qapi documents a better behavior for users. We should fix the code instead to mach the docs. 1. Using disk name as a bitmap name is a bad behavior, as they are completely different concepts. Especially keeping in mind t

Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-20 Thread Vladimir Sementsov-Ogievskiy
19.12.2019 19:14, Nir Soffer wrote: > On Thu, Dec 19, 2019 at 5:25 PM Vladimir Sementsov-Ogievskiy > wrote: >> >> 19.12.2019 18:08, Nir Soffer wrote: >>> On Thu, Dec 19, 2019 at 5:00 PM Vladimir Sementsov-Ogievskiy >>> wrote: 19.12.2019 17:42, Nir Soffer wrote: > On Thu, Dec 19, 201

Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-19 Thread Nir Soffer
On Thu, Dec 19, 2019 at 5:25 PM Vladimir Sementsov-Ogievskiy wrote: > > 19.12.2019 18:08, Nir Soffer wrote: > > On Thu, Dec 19, 2019 at 5:00 PM Vladimir Sementsov-Ogievskiy > > wrote: > >> > >> 19.12.2019 17:42, Nir Soffer wrote: > >>> On Thu, Dec 19, 2019 at 4:34 PM Vladimir Sementsov-Ogievskiy

Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2019 18:08, Nir Soffer wrote: > On Thu, Dec 19, 2019 at 5:00 PM Vladimir Sementsov-Ogievskiy > wrote: >> >> 19.12.2019 17:42, Nir Soffer wrote: >>> On Thu, Dec 19, 2019 at 4:34 PM Vladimir Sementsov-Ogievskiy >>> wrote: "NAME" here may be interpreted like it should match @name, wh

Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-19 Thread Nir Soffer
On Thu, Dec 19, 2019 at 5:00 PM Vladimir Sementsov-Ogievskiy wrote: > > 19.12.2019 17:42, Nir Soffer wrote: > > On Thu, Dec 19, 2019 at 4:34 PM Vladimir Sementsov-Ogievskiy > > wrote: > >> > >> "NAME" here may be interpreted like it should match @name, which is > >> export name. But it was never

Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2019 17:42, Nir Soffer wrote: > On Thu, Dec 19, 2019 at 4:34 PM Vladimir Sementsov-Ogievskiy > wrote: >> >> "NAME" here may be interpreted like it should match @name, which is >> export name. But it was never mentioned in such way. Make it obvious, >> that actual "" (see docs/interop/nbd.txt

Re: [PATCH] qapi/block: fix nbd-server-add spec

2019-12-19 Thread Nir Soffer
On Thu, Dec 19, 2019 at 4:34 PM Vladimir Sementsov-Ogievskiy wrote: > > "NAME" here may be interpreted like it should match @name, which is > export name. But it was never mentioned in such way. Make it obvious, > that actual "" (see docs/interop/nbd.txt) > will match @bitmap parameter. But this

[PATCH] qapi/block: fix nbd-server-add spec

2019-12-19 Thread Vladimir Sementsov-Ogievskiy
"NAME" here may be interpreted like it should match @name, which is export name. But it was never mentioned in such way. Make it obvious, that actual "" (see docs/interop/nbd.txt) will match @bitmap parameter. Fixes: 5fcbeb06812685a2 Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all. This