On 10/13/24 10:36 PM, dan tan wrote:
Hi Stefan,
Thank you for the review comments! Please see my response below.
thank you,
---
dan tan
power simulation
phone:+1.7373.099.138
email:dan...@linux.ibm.com
On 2024-09-12 13:02, Stefan Berger wrote:
On 9/12/24 12:09 PM, dan tan wrote:
From: da
Hello Dan,
On 10/14/24 02:08, dan tan wrote:
Hi Cédric,
Thank you for the review comments. Please see my response below.
thank you,
---
dan tan
power simulation
phone:+1.7373.099.138
email:dan...@linux.ibm.com
On 2024-09-12 12:20, Cédric Le Goater wrote:
Hello Dan,
On 9/12/24 18:09, dan ta
Hi Stefan,
Thank you for the review comments! Please see my response below.
thank you,
---
dan tan
power simulation
phone:+1.7373.099.138
email:dan...@linux.ibm.com
On 2024-09-12 13:02, Stefan Berger wrote:
On 9/12/24 12:09 PM, dan tan wrote:
From: dan tan
SPI interface to TPM TIS implemen
Hi Cédric,
Thank you for the review comments. Please see my response below.
thank you,
---
dan tan
power simulation
phone:+1.7373.099.138
email:dan...@linux.ibm.com
On 2024-09-12 12:20, Cédric Le Goater wrote:
Hello Dan,
On 9/12/24 18:09, dan tan wrote:
From: dan tan
SPI interface to TPM
On 9/12/24 12:09 PM, dan tan wrote:
From: dan tan
SPI interface to TPM TIS implementation via swtpm
Apart from Cedric's comments:
Can you say a bit more about the specs you followed and details how many
localities are supported etc. Is this device pnv-specific or can it be
used on other
Hello Dan,
On 9/12/24 18:09, dan tan wrote:
From: dan tan
SPI interface to TPM TIS implementation via swtpm
I would split this patch in 3 :
1. device model
2. activation for the PowerNV machines
3. unit tests
Each with a slightly more detailed commit log please. one line
is very minimal fo
From: dan tan
SPI interface to TPM TIS implementation via swtpm
Signed-off-by: dan tan
---
include/sysemu/tpm.h | 3 +
hw/tpm/tpm_tis_spi.c | 347 +
tests/qtest/pnv-tpm-tis-spi-test.c | 223 ++
hw/ppc/Kconfig