Re: [PATCH] plugins: fix win plugin tests on cross compile

2023-11-09 Thread Philippe Mathieu-Daudé
Hi Greg, On 9/11/23 10:13, Greg Manning wrote: > fixes #1927. Does this match the GitLab pattern? See https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#default-closing-pattern We usually write: "Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1927"; So there is no conf

Re: [PATCH] plugins: fix win plugin tests on cross compile

2023-11-09 Thread Philippe Mathieu-Daudé
Hi Greg, On 9/11/23 10:13, Greg Manning wrote: fixes #1927. Does this match GitLab pattern? See https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#default-closing-pattern We usually write: "Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1927"; So there is no confusi

[PATCH] plugins: fix win plugin tests on cross compile

2023-11-09 Thread Greg Manning
fixes #1927. Cross compile gcc is more picky about argument order than msys. Changed the meson command to take the (now renamed) libqemu_plugin_api.a as a lib, rather than an object. This puts it in the right place on both native and cross compile gcc commands Reenable plugins on crossbuilds ---