Re: [PATCH] plugins: Set final instruction count in plugin_gen_tb_end

2023-07-14 Thread Matt Borgerson
Hi Philippe, > num_insns is a 'size_t'. You are right. I copied the `int` type from `DisasContextBase`, but it should really be `size_t`. I'll send an updated patch. Thanks, Matt On Fri, Jul 14, 2023 at 11:09 AM Philippe Mathieu-Daudé wrote: > > Hi Matt, > > On 14/7/23 06:18, Matt Borgerson wr

Re: [PATCH] plugins: Set final instruction count in plugin_gen_tb_end

2023-07-14 Thread Philippe Mathieu-Daudé
Hi Matt, On 14/7/23 06:18, Matt Borgerson wrote: Translation logic may partially decode an instruction, then abort and remove the instruction from the TB. This can happen for example when an instruction spans two pages. In this case, plugins may get an incorrect result when calling qemu_plugin_t

[PATCH] plugins: Set final instruction count in plugin_gen_tb_end

2023-07-13 Thread Matt Borgerson
Translation logic may partially decode an instruction, then abort and remove the instruction from the TB. This can happen for example when an instruction spans two pages. In this case, plugins may get an incorrect result when calling qemu_plugin_tb_n_insns to query for the number of instructions in