Re: [PATCH] plugin: fix clearing of plugin_mem_cbs before TB exit

2023-03-01 Thread Emilio Cota
On Tue, Feb 28, 2023 at 10:50:26 -1000, Richard Henderson wrote: > On 2/21/23 18:32, Emilio Cota wrote: > > Currently we are wrongly accessing plugin_tb->mem_helper at > > translation time from plugin_gen_disable_mem_helpers, which is > > called before generating a TB exit, e.g. with exit_tb. > >

Re: [PATCH] plugin: fix clearing of plugin_mem_cbs before TB exit

2023-02-28 Thread Richard Henderson
On 2/21/23 18:32, Emilio Cota wrote: Currently we are wrongly accessing plugin_tb->mem_helper at translation time from plugin_gen_disable_mem_helpers, which is called before generating a TB exit, e.g. with exit_tb. Recall that it is only during TB finalisation, i.e. when we go over the TB post-t

Re: [PATCH] plugin: fix clearing of plugin_mem_cbs before TB exit

2023-02-28 Thread Frédéric Pétrot
Le 22/02/2023 à 05:32, Emilio Cota a écrit : Currently we are wrongly accessing plugin_tb->mem_helper at translation time from plugin_gen_disable_mem_helpers, which is called before generating a TB exit, e.g. with exit_tb. Recall that it is only during TB finalisation, i.e. when we go over the T

[PATCH] plugin: fix clearing of plugin_mem_cbs before TB exit

2023-02-21 Thread Emilio Cota
Currently we are wrongly accessing plugin_tb->mem_helper at translation time from plugin_gen_disable_mem_helpers, which is called before generating a TB exit, e.g. with exit_tb. Recall that it is only during TB finalisation, i.e. when we go over the TB post-translation to inject or remove plugin i